Hi On Thu, Jun 9, 2016 at 12:07 PM, Victor Kaplansky <vict...@redhat.com> wrote: > What if set_vring_base is called after set_vring_addr? > Maybe it is worth to add the fixup to the set_vring_base as well?
It would need to handle conditions like set_vring_base() being called while set_vring_addr() is not yet, and thus vq->used isn't set. Imho it's not necessary, since order is currently fixed in vhost_virtqueue_start(), but we could specify this in the protocol to avoid too much possible states. -- Marc-André Lureau