"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> Added doc comments for existing functions comment and rewrite them in
>> a common style.
>>
>> Signed-off-by: Juan Quintela
>> ---
>> migration/ram.c | 348
>> -
"Dr. David Alan Gilbert" wrote:
> * Peter Xu (pet...@redhat.com) wrote:
>> Hi, Juan,
>>
>> Got several nitpicks below... (along with some questions)
>>
>> On Thu, Mar 23, 2017 at 09:44:54PM +0100, Juan Quintela wrote:
>>
>> [...]
>
>> > @@ -1157,11 +1186,12 @@ static bool get_queued_page(Migrat
* Juan Quintela (quint...@redhat.com) wrote:
> Added doc comments for existing functions comment and rewrite them in
> a common style.
>
> Signed-off-by: Juan Quintela
> ---
> migration/ram.c | 348
>
> 1 file changed, 227 insertions(+),
* Peter Xu (pet...@redhat.com) wrote:
> Hi, Juan,
>
> Got several nitpicks below... (along with some questions)
>
> On Thu, Mar 23, 2017 at 09:44:54PM +0100, Juan Quintela wrote:
>
> [...]
> > @@ -1157,11 +1186,12 @@ static bool get_queued_page(MigrationState *ms,
> > PageSearchStatus *pss,
>
Peter Xu wrote:
> On Fri, Mar 24, 2017 at 12:44:06PM +0100, Juan Quintela wrote:
>> >
>> > Here the comment says (just like mentioned in function name) that we
>> > will "flush any remaining pages in the ram request queue", however in
>> > the implementation, we should be only freeing everything
On Fri, Mar 24, 2017 at 12:44:06PM +0100, Juan Quintela wrote:
> Peter Xu wrote:
> > Hi, Juan,
> >
> > Got several nitpicks below... (along with some questions)
> >
> > On Thu, Mar 23, 2017 at 09:44:54PM +0100, Juan Quintela wrote:
> >
> > [...]
> >
> >> static void xbzrle_cache_zero_page(ram_add
Peter Xu wrote:
> Hi, Juan,
>
> Got several nitpicks below... (along with some questions)
>
> On Thu, Mar 23, 2017 at 09:44:54PM +0100, Juan Quintela wrote:
>
> [...]
>
>> static void xbzrle_cache_zero_page(ram_addr_t current_addr)
>> {
>> @@ -459,8 +474,8 @@ static void xbzrle_cache_zero_page(r
Hi, Juan,
Got several nitpicks below... (along with some questions)
On Thu, Mar 23, 2017 at 09:44:54PM +0100, Juan Quintela wrote:
[...]
> static void xbzrle_cache_zero_page(ram_addr_t current_addr)
> {
> @@ -459,8 +474,8 @@ static void xbzrle_cache_zero_page(ram_addr_t
> current_addr)
> *
Added doc comments for existing functions comment and rewrite them in
a common style.
Signed-off-by: Juan Quintela
---
migration/ram.c | 348
1 file changed, 227 insertions(+), 121 deletions(-)
diff --git a/migration/ram.c b/migration/ram
