Peter Xu <pet...@redhat.com> wrote: > On Fri, Mar 24, 2017 at 12:44:06PM +0100, Juan Quintela wrote:
>> > >> > Here the comment says (just like mentioned in function name) that we >> > will "flush any remaining pages in the ram request queue", however in >> > the implementation, we should be only freeing everything in >> > src_page_requests. The problem is "flush" let me think about "flushing >> > the rest of the pages to the other side"... while it's not. >> > >> > Would it be nice we just rename the function into something else, like >> > migration_page_queue_free()? We can tune the comments correspondingly >> > as well. >> >> I will let this one to dave to answer O:-) >> I agree than previous name is not perfect, but not sure that the new one >> is mucth better either. >> >> migration_drop_page_queue()? > > This is indeed a nitpick of mine... So please feel free to ignore it. > :) > > But if we will keep the function name, I would slightly prefer that at > least we mention in the comment that, this is only freeing things up, > not sending anything out. Added that to the comment. Thanks, Juan.
