Re: [Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR

2012-09-10 Thread Aurelien Jarno
On Mon, Sep 10, 2012 at 07:45:04AM -0700, Richard Henderson wrote: > On 09/10/2012 07:34 AM, Aurelien Jarno wrote: > > If it is not possible to implement your FPR code using these functions, > > we might want to add some more, but I really thing it's a bad idea to > > have this code in the targets.

Re: [Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR

2012-09-10 Thread Richard Henderson
On 09/10/2012 07:34 AM, Aurelien Jarno wrote: > If it is not possible to implement your FPR code using these functions, > we might want to add some more, but I really thing it's a bad idea to > have this code in the targets. I thought I got rid of all this in the various rebasing. Certainly it's

Re: [Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR

2012-09-10 Thread Aurelien Jarno
On Sun, Sep 09, 2012 at 02:04:25PM -0700, Richard Henderson wrote: > At the same time, tidy other usages of tcg_gen_deposit_i64. > In some cases we can "type cast" rather than extend, and in > others we can allow tcg_gen_deposit_i64 itself to optimize > the HOST_LONG_BITS==32 case. > > Signed-off-

[Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR

2012-09-09 Thread Richard Henderson
At the same time, tidy other usages of tcg_gen_deposit_i64. In some cases we can "type cast" rather than extend, and in others we can allow tcg_gen_deposit_i64 itself to optimize the HOST_LONG_BITS==32 case. Signed-off-by: Richard Henderson --- target-s390x/translate.c | 68 +