Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors

2015-01-08 Thread John Snow
On 09/18/2014 07:43 PM, John Snow wrote: The original version of the AHCI test base which is now staged for being merged, processes the ahci_identify test in a monolithic fashion. In authoring new tests, it became necessary and obvious as to how the operation of this device should be factored

Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors

2014-11-03 Thread John Snow
PING for this refactor series, which will allow me to check in more AHCI tests. To assist review, I'll annotate this cover letter a little bit with some additional information. The hardest/ugliest patch to review is the first one, but it is primarily just variable name/location changes and not

Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors

2014-09-19 Thread John Snow
On 09/19/2014 06:53 AM, Markus Armbruster wrote: John Snow writes: The original version of the AHCI test base which is now staged for being merged, processes the ahci_identify test in a monolithic fashion. In authoring new tests, it became necessary and obvious as to how the operation of th

Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors

2014-09-19 Thread Stefan Hajnoczi
On Fri, Sep 19, 2014 at 12:53:22PM +0200, Markus Armbruster wrote: > John Snow writes: > > > The original version of the AHCI test base > > which is now staged for being merged, processes > > the ahci_identify test in a monolithic fashion. > > > > In authoring new tests, it became necessary and >

Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors

2014-09-19 Thread Markus Armbruster
John Snow writes: > The original version of the AHCI test base > which is now staged for being merged, processes > the ahci_identify test in a monolithic fashion. > > In authoring new tests, it became necessary and > obvious as to how the operation of this device > should be factored out to ease

[Qemu-devel] [PATCH 00/15] AHCI test helper refactors

2014-09-18 Thread John Snow
The original version of the AHCI test base which is now staged for being merged, processes the ahci_identify test in a monolithic fashion. In authoring new tests, it became necessary and obvious as to how the operation of this device should be factored out to ease the writing of new AHCI tests. T