Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 14:27, Peter Maydell wrote: > So does this mean that we still have other broken options? Do we > have a timescale for fixing them? I was hoping to be able to commit > a patchset fixing these regressions this week; if we can't do that > then we should probably revert the original cha

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-08 Thread Peter Maydell
On 6 January 2015 at 13:29, Marcel Apfelbaum wrote: > Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This resulted in a Qemu crash: > $ qemu-system-x86_64 -usb > q

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-07 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 03:29:11PM +0200, Marcel Apfelbaum wrote: > Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This resulted in a Qemu crash: > $ qemu-system-x

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 22:54, Alexander Graf wrote: > > > On 06.01.15 21:41, Paolo Bonzini wrote: >> >> >> On 06/01/2015 20:48, Paolo Bonzini wrote: >>> I like the way you structured the series! >>> >>> Reviewed-by: Paolo Bonzini >> >> Hmm, actually doesn't this break -machine usb=no? > > I think it d

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Alexander Graf
On 06.01.15 21:41, Paolo Bonzini wrote: > > > On 06/01/2015 20:48, Paolo Bonzini wrote: >> I like the way you structured the series! >> >> Reviewed-by: Paolo Bonzini > > Hmm, actually doesn't this break -machine usb=no? I think it does, but I don't think we really need to care. We can just a

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 20:48, Paolo Bonzini wrote: > I like the way you structured the series! > > Reviewed-by: Paolo Bonzini Hmm, actually doesn't this break -machine usb=no? Paolo

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 14:29, Marcel Apfelbaum wrote: > Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This resulted in a Qemu crash: > $ qemu-system-x86_64 -usb > qemu-s

[Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Marcel Apfelbaum
Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This resulted in a Qemu crash: $ qemu-system-x86_64 -usb qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helpe