Re: [Qemu-devel] [PATCH 0/2] pci: handle zero size ROM files gracefully

2013-03-11 Thread Michael S. Tsirkin
On Mon, Mar 11, 2013 at 10:20:19AM +0100, Stefan Hajnoczi wrote: > This is a fix for https://bugs.launchpad.net/qemu/+bug/1127053. > > If pxe-e1000.rom has 0 size we allocate the same RAMBlock offset twice and > fail > with an assertion in qemu_ram_set_idstr() later on. > > Two fixes: > > 1. Pr

[Qemu-devel] [PATCH 0/2] pci: handle zero size ROM files gracefully

2013-03-11 Thread Stefan Hajnoczi
This is a fix for https://bugs.launchpad.net/qemu/+bug/1127053. If pxe-e1000.rom has 0 size we allocate the same RAMBlock offset twice and fail with an assertion in qemu_ram_set_idstr() later on. Two fixes: 1. Print an error when the ROM file has zero size. Use -device ...,romfile= instead t