On Mon, Mar 11, 2013 at 10:20:19AM +0100, Stefan Hajnoczi wrote: > This is a fix for https://bugs.launchpad.net/qemu/+bug/1127053. > > If pxe-e1000.rom has 0 size we allocate the same RAMBlock offset twice and > fail > with an assertion in qemu_ram_set_idstr() later on. > > Two fixes: > > 1. Print an error when the ROM file has zero size. Use -device ...,romfile= > instead to disable the ROM. > > 2. Add an assertion to find_ram_offset() so we watch this inconsistency if it > ever happens again. > > Stefan Hajnoczi (2): > pci: refuse empty ROM files > exec: assert that RAMBlock size is non-zero > > exec.c | 2 ++ > hw/pci/pci.c | 7 ++++++- > 2 files changed, 8 insertions(+), 1 deletion(-)
Applied, thanks. > -- > 1.8.1.4