Re: [Qemu-devel] [PATCH] watchdog: convert to QemuOpts

2015-05-27 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 27/05/2015 15:00, Eric Blake wrote: > Should this be > > -watchdog [model=]i6300esb|ib700[,action=...none] > > to make it obvious that ,action= is optional for back-compat with > old usage? Sure, but then it should be -watchdog [[model=]i

Re: [Qemu-devel] [PATCH] watchdog: convert to QemuOpts

2015-05-27 Thread Eric Blake
On 05/27/2015 06:35 AM, Paolo Bonzini wrote: > This makes it possible to specify a watchdog action in a configuration file. > The previous behavior of "-watchdog" is moved to the (implied) "-watchdog > model" suboption. This is already more or less obsolete, since it is possible > to achieve the s

Re: [Qemu-devel] [PATCH] watchdog: convert to QemuOpts

2015-05-27 Thread Richard W.M. Jones
On Wed, May 27, 2015 at 02:45:29PM +0200, Paolo Bonzini wrote: > > > On 27/05/2015 14:41, Richard W.M. Jones wrote: > >> > -if (watchdog) { > >> > -fprintf(stderr, > >> > -"qemu: only one watchdog option may be > >> > given\n"); > >

Re: [Qemu-devel] [PATCH] watchdog: convert to QemuOpts

2015-05-27 Thread Paolo Bonzini
On 27/05/2015 14:41, Richard W.M. Jones wrote: >> > -if (watchdog) { >> > -fprintf(stderr, >> > -"qemu: only one watchdog option may be >> > given\n"); >> > -return 1; >> > +olist = qemu_find_opts

Re: [Qemu-devel] [PATCH] watchdog: convert to QemuOpts

2015-05-27 Thread Paolo Bonzini
On 27/05/2015 14:41, Richard W.M. Jones wrote: > On Wed, May 27, 2015 at 02:35:26PM +0200, Paolo Bonzini wrote: >> case QEMU_OPTION_watchdog: >> -if (watchdog) { >> -fprintf(stderr, >> -"qemu: only one watchdog option ma

Re: [Qemu-devel] [PATCH] watchdog: convert to QemuOpts

2015-05-27 Thread Richard W.M. Jones
On Wed, May 27, 2015 at 02:35:26PM +0200, Paolo Bonzini wrote: > case QEMU_OPTION_watchdog: > -if (watchdog) { > -fprintf(stderr, > -"qemu: only one watchdog option may be given\n"); > -return 1; > +

[Qemu-devel] [PATCH] watchdog: convert to QemuOpts

2015-05-27 Thread Paolo Bonzini
This makes it possible to specify a watchdog action in a configuration file. The previous behavior of "-watchdog" is moved to the (implied) "-watchdog model" suboption. This is already more or less obsolete, since it is possible to achieve the same effect with "-device", but "-watchdog-action does