Re: [Qemu-devel] [PATCH] vnc: remove bogus object_unref on client socket

On Thu, Feb 15, 2018 at 01:24:14PM -0500, Bandan Das wrote: > Daniel P. Berrangé writes: > > > vnc_listen_io() does not own the reference on the 'cioc' parameter is it > > passed, so should not be unref'ing it. > > > > Reported-by: Bandan Das > > Signed-off-by: Daniel P. Berrangé > > Daniel, w

Re: [Qemu-devel] [PATCH] vnc: remove bogus object_unref on client socket

Daniel P. Berrangé writes: > vnc_listen_io() does not own the reference on the 'cioc' parameter is it > passed, so should not be unref'ing it. > > Reported-by: Bandan Das > Signed-off-by: Daniel P. Berrangé Daniel, wouldn't a Fixes: 13e1d0e71e78a925848258391a6e616b6b5ae219 be helpful here ? >

Re: [Qemu-devel] [PATCH] vnc: remove bogus object_unref on client socket

On 02/15/2018 04:26 AM, Daniel P. Berrangé wrote: vnc_listen_io() does not own the reference on the 'cioc' parameter is it passed, so should not be unref'ing it. Reported-by: Bandan Das Signed-off-by: Daniel P. Berrangé --- ui/vnc.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Eric B

[Qemu-devel] [PATCH] vnc: remove bogus object_unref on client socket

vnc_listen_io() does not own the reference on the 'cioc' parameter is it passed, so should not be unref'ing it. Reported-by: Bandan Das Signed-off-by: Daniel P. Berrangé --- ui/vnc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index c715bae1cf..b97769aa9e 100644 --- a