Daniel P. Berrangé <berra...@redhat.com> writes: > vnc_listen_io() does not own the reference on the 'cioc' parameter is it > passed, so should not be unref'ing it. > > Reported-by: Bandan Das <b...@redhat.com> > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Daniel, wouldn't a Fixes: 13e1d0e71e78a925848258391a6e616b6b5ae219 be helpful here ? > --- > ui/vnc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index c715bae1cf..b97769aa9e 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -3152,7 +3152,6 @@ static void vnc_listen_io(QIONetListener *listener, > isWebsock ? "vnc-ws-server" : "vnc-server"); > qio_channel_set_delay(QIO_CHANNEL(cioc), false); > vnc_connect(vd, cioc, false, isWebsock); > - object_unref(OBJECT(cioc)); > } > > static const DisplayChangeListenerOps dcl_ops = {