Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-17 Thread Markus Armbruster
Markus Armbruster writes: > Error classes are a leftover from the days of "rich" error objects. > New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f > added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Forgot to spell it out: this needs to go into 2.3, because it fixes

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-16 Thread Fam Zheng
On Fri, 03/13 17:56, Peter Maydell wrote: > On 13 March 2015 at 17:50, Patchew Tool wrote: > > > > This series passed Patchew automatic testing, but there are some warnings. > > > > Find the log fragments below, or open the following URL to see the full log: > > > > http://qemu.patchew.org/testing

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Eric Blake
On 03/13/2015 11:48 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f >> added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. "always" is

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread John Snow
On 03/13/2015 01:56 PM, Peter Maydell wrote: On 13 March 2015 at 17:50, Patchew Tool wrote: This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<142626858

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Peter Maydell
On 13 March 2015 at 17:50, Patchew Tool wrote: > > This series passed Patchew automatic testing, but there are some warnings. > > Find the log fragments below, or open the following URL to see the full log: > > http://qemu.patchew.org/testing/log/<1426268589-14756-1-git-send-email-arm...@redhat.co

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426268589-14756-1-git-send-email-arm...@redhat.com> --8<- === Starting docker === Copy

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Markus Armbruster
Markus Armbruster writes: > Error classes are a leftover from the days of "rich" error objects. > New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f > added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Signed-off-by: Markus Armbruster > ui/vnc.c | 2 +- > 1 file chan

[Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-13 Thread Markus Armbruster
Error classes are a leftover from the days of "rich" error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c i