Re: [Qemu-devel] [PATCH] virtio-blk: Release s->rq queue at system_reset

2016-08-02 Thread Fam Zheng
On Tue, 08/02 15:24, Fam Zheng wrote: > On Tue, 08/02 08:46, Paolo Bonzini wrote: > > > > > > On 29/07/2016 12:22, Fam Zheng wrote: > > > At system_reset, there is no point in retrying the queued request, > > > because the driver that issued the request won't be around any more. > > > > > > Anal

Re: [Qemu-devel] [PATCH] virtio-blk: Release s->rq queue at system_reset

2016-08-02 Thread Fam Zheng
On Tue, 08/02 08:46, Paolo Bonzini wrote: > > > On 29/07/2016 12:22, Fam Zheng wrote: > > At system_reset, there is no point in retrying the queued request, > > because the driver that issued the request won't be around any more. > > > > Analyzed-by: Laszlo Ersek > > Reported-by: Laszlo Ersek

Re: [Qemu-devel] [PATCH] virtio-blk: Release s->rq queue at system_reset

2016-08-01 Thread Paolo Bonzini
On 29/07/2016 12:22, Fam Zheng wrote: > At system_reset, there is no point in retrying the queued request, > because the driver that issued the request won't be around any more. > > Analyzed-by: Laszlo Ersek > Reported-by: Laszlo Ersek > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c

Re: [Qemu-devel] [PATCH] virtio-blk: Release s->rq queue at system_reset

2016-07-31 Thread Fam Zheng
On Fri, 07/29 12:41, Laszlo Ersek wrote: > So how about turning this patch into a two part series: the first patch > should drop the comment, and reference > 6e40b3bfc7e82823cf4df5f0bf668f56db41e53a, while the second patch should be > this patch? Good idea, I'm sending a separate patch to remove t

Re: [Qemu-devel] [PATCH] virtio-blk: Release s->rq queue at system_reset

2016-07-29 Thread Laszlo Ersek
Fam, On 07/29/16 12:22, Fam Zheng wrote: > At system_reset, there is no point in retrying the queued request, > because the driver that issued the request won't be around any more. > > Analyzed-by: Laszlo Ersek > Reported-by: Laszlo Ersek > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk

[Qemu-devel] [PATCH] virtio-blk: Release s->rq queue at system_reset

2016-07-29 Thread Fam Zheng
At system_reset, there is no point in retrying the queued request, because the driver that issued the request won't be around any more. Analyzed-by: Laszlo Ersek Reported-by: Laszlo Ersek Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git