Re: [Qemu-devel] [PATCH] tcg/mips: fix broken CONFIG_TCG_PASS_AREG0 code

2012-08-28 Thread Aurelien Jarno
On Tue, Aug 28, 2012 at 01:19:21PM +0100, Peter Maydell wrote: > On 27 August 2012 23:51, Aurelien Jarno wrote: > > The CONFIG_TCG_PASS_AREG0 code for calling ld/st helpers was > > broken in that it did not respect the ABI requirement that 64 > > bit values were passed in even-odd register pairs.

Re: [Qemu-devel] [PATCH] tcg/mips: fix broken CONFIG_TCG_PASS_AREG0 code

2012-08-28 Thread Peter Maydell
On 27 August 2012 23:51, Aurelien Jarno wrote: > The CONFIG_TCG_PASS_AREG0 code for calling ld/st helpers was > broken in that it did not respect the ABI requirement that 64 > bit values were passed in even-odd register pairs. The simplest > way to fix this is to implement some new utility functio

[Qemu-devel] [PATCH] tcg/mips: fix broken CONFIG_TCG_PASS_AREG0 code

2012-08-27 Thread Aurelien Jarno
The CONFIG_TCG_PASS_AREG0 code for calling ld/st helpers was broken in that it did not respect the ABI requirement that 64 bit values were passed in even-odd register pairs. The simplest way to fix this is to implement some new utility functions for marshalling function arguments into the correct r