Re: [Qemu-devel] [PATCH] target-mips: use CP0EnLo_XI instead of magic number

2015-01-29 Thread Maciej W. Rozycki
On Thu, 29 Jan 2015, Leon Alrae wrote: > > And do we want to have CP0C3_LPA set in the few templates that do in the > > first place? AFAICT we don't really implement LPA so this bit will > > confuse software. Of course implementing it would be another option, not > > very complicated AFAICS,

Re: [Qemu-devel] [PATCH] target-mips: use CP0EnLo_XI instead of magic number

2015-01-29 Thread Leon Alrae
On 28/01/2015 23:11, Maciej W. Rozycki wrote: >> @@ -4947,7 +4947,7 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, int >> reg, int sel) >> #if defined(TARGET_MIPS64) >> if (ctx->rxi) { >> TCGv tmp = tcg_temp_new(); >> -tcg_gen_andi_tl(tmp, arg,

Re: [Qemu-devel] [PATCH] target-mips: use CP0EnLo_XI instead of magic number

2015-01-28 Thread Maciej W. Rozycki
On Mon, 26 Jan 2015, Leon Alrae wrote: > Signed-off-by: Leon Alrae > --- Enthusiastically: Reviewed-by: Maciej W. Rozycki However... > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 635192c..77d89be 100644 > --- a/target-mips/translate.c > +++ b/target-mips/translat

[Qemu-devel] [PATCH] target-mips: use CP0EnLo_XI instead of magic number

2015-01-26 Thread Leon Alrae
Signed-off-by: Leon Alrae --- target-mips/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 635192c..77d89be 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -4947,7 +4947,7 @@ static vo