Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 12:31:42PM +0100, Paolo Bonzini wrote: > > On 02/11/2014 11:19, Michael S. Tsirkin wrote: > > > Add AVX512 feature bits, register definition and corresponding > > > xsave/vmstate support. > > > > > > Signed-off-by: Chao Peng > > > > Thanks! > > > > As this was first pos

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-11-03 Thread Paolo Bonzini
On 02/11/2014 11:19, Michael S. Tsirkin wrote: > > Add AVX512 feature bits, register definition and corresponding > > xsave/vmstate support. > > > > Signed-off-by: Chao Peng > > Thanks! > > As this was first posted after soft freeze, please > resubmit after 2.2 is out. > > See schedule http:/

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-11-02 Thread Chao Peng
On Sun, Nov 02, 2014 at 12:19:09PM +0200, Michael S. Tsirkin wrote: > On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: > > Add AVX512 feature bits, register definition and corresponding > > xsave/vmstate support. > > > > Signed-off-by: Chao Peng > > Thanks! > > As this was first poste

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-11-02 Thread Michael S. Tsirkin
On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: > Add AVX512 feature bits, register definition and corresponding > xsave/vmstate support. > > Signed-off-by: Chao Peng Thanks! As this was first posted after soft freeze, please resubmit after 2.2 is out. See schedule http://wiki.qemu.

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-27 Thread Paolo Bonzini
On 10/27/2014 04:48 PM, Eduardo Habkost wrote: > On Fri, Oct 24, 2014 at 07:55:10AM +0200, Paolo Bonzini wrote: > [...] >> I think we can keep the macros. The actual cleanup would be to have a >> single member for the 32 512-bit ZMM registers, instead of splitting >> xmm/ymmh/zmmh/zmm_hi16. Thi

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-27 Thread Eduardo Habkost
On Fri, Oct 24, 2014 at 07:55:10AM +0200, Paolo Bonzini wrote: [...] > I think we can keep the macros. The actual cleanup would be to have a > single member for the 32 512-bit ZMM registers, instead of splitting > xmm/ymmh/zmmh/zmm_hi16. This will get rid of the YMM_* and ZMM_* > registers. Howe

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-26 Thread Chao Peng
On Fri, Oct 24, 2014 at 02:01:44PM -0200, Eduardo Habkost wrote: > On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: > > Add AVX512 feature bits, register definition and corresponding > > xsave/vmstate support. > > > > Signed-off-by: Chao Peng > > --- > [...] I agree to the cleanup sche

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-24 Thread Eduardo Habkost
On Thu, Oct 23, 2014 at 04:34:46PM +0200, Paolo Bonzini wrote: > On 10/23/2014 05:02 AM, Chao Peng wrote: > > Add AVX512 feature bits, register definition and corresponding > > xsave/vmstate support. > > > > Signed-off-by: Chao Peng > > --- > > target-i386/cpu.c | 10 -- > > target-i38

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-24 Thread Eduardo Habkost
On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: > Add AVX512 feature bits, register definition and corresponding > xsave/vmstate support. > > Signed-off-by: Chao Peng > --- [...] > @@ -745,6 +829,9 @@ VMStateDescription vmstate_x86_cpu = { > }, { > .vmsd = &vmstat

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-24 Thread Paolo Bonzini
On 10/24/2014 01:12 PM, Eduardo Habkost wrote: >> > I think we can keep the macros. The actual cleanup would be to have a >> > single member for the 32 512-bit ZMM registers, instead of splitting >> > xmm/ymmh/zmmh/zmm_hi16. This will get rid of the YMM_* and ZMM_* >> > registers. However, we

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-24 Thread Eduardo Habkost
On Fri, Oct 24, 2014 at 07:55:10AM +0200, Paolo Bonzini wrote: > > > On 10/24/2014 03:27 AM, Chao Peng wrote: > > On Thu, Oct 23, 2014 at 05:49:23PM -0200, Eduardo Habkost wrote: > >> On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: > >> [...] > >>> @@ -707,6 +714,24 @@ typedef union {

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-23 Thread Paolo Bonzini
On 10/24/2014 03:27 AM, Chao Peng wrote: > On Thu, Oct 23, 2014 at 05:49:23PM -0200, Eduardo Habkost wrote: >> On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: >> [...] >>> @@ -707,6 +714,24 @@ typedef union { >>> } XMMReg; >>> >>> typedef union { >>> +uint8_t _b[32]; >>> +u

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-23 Thread Chao Peng
On Thu, Oct 23, 2014 at 05:49:23PM -0200, Eduardo Habkost wrote: > On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: > [...] > > @@ -707,6 +714,24 @@ typedef union { > > } XMMReg; > > > > typedef union { > > +uint8_t _b[32]; > > +uint16_t _w[16]; > > +uint32_t _l[8]; > > +

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-23 Thread Eduardo Habkost
On Thu, Oct 23, 2014 at 11:02:43AM +0800, Chao Peng wrote: [...] > @@ -707,6 +714,24 @@ typedef union { > } XMMReg; > > typedef union { > +uint8_t _b[32]; > +uint16_t _w[16]; > +uint32_t _l[8]; > +uint64_t _q[4]; > +float32 _s[8]; > +float64 _d[4]; > +} YMMReg; > + > +ty

Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-23 Thread Paolo Bonzini
On 10/23/2014 05:02 AM, Chao Peng wrote: > Add AVX512 feature bits, register definition and corresponding > xsave/vmstate support. > > Signed-off-by: Chao Peng > --- > target-i386/cpu.c | 10 -- > target-i386/cpu.h | 61 ++ > target-i386/kvm.c

[Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support

2014-10-22 Thread Chao Peng
Add AVX512 feature bits, register definition and corresponding xsave/vmstate support. Signed-off-by: Chao Peng --- target-i386/cpu.c | 10 -- target-i386/cpu.h | 61 ++ target-i386/kvm.c | 19 +++ target-i386/machine.c | 87