Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

2018-11-14 Thread Aleksandar Markovic
Fredrik wrote: > Philippe wrote: > > > Then we will fix this for the 4.0 release. > > What exactly needs to be fixed regarding the psABI? The relevant opcodes > would need to stay, and not be prohibited and removed as Aleksandar has > suggested, since such opcode removal breaks the psABI requirem

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

2018-11-14 Thread Philippe Mathieu-Daudé
Hi Fredrik, On Wed, Nov 14, 2018 at 4:31 PM Fredrik Noring wrote: > On Tue, Nov 13, 2018 at 11:51:54PM +0100, Philippe Mathieu-Daudé wrote: [...] > > At some point while reading your reviews, I understood the R5900 > > patches introduced incorrect behaviors for the non-R5900 cpus. In this > > cas

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

2018-11-14 Thread Philippe Mathieu-Daudé
On Wed, Nov 14, 2018 at 3:02 PM Aleksandar Markovic wrote: > Philippe Mathieu-Daudé wrote: > > > Can you add: > > > > This reverts commit ed4f49ba9bb56ebca6987b1083255daf6c89b5de. > > > > Or > > > > Fixes: ed4f49ba9 > > > > when applying? > > Sure, I'll add something along that line. > > > If the

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

2018-11-14 Thread Fredrik Noring
Hi Philippe, On Tue, Nov 13, 2018 at 11:51:54PM +0100, Philippe Mathieu-Daudé wrote: > On Tue, Nov 13, 2018 at 8:29 PM Philippe Mathieu-Daudé > wrote: > > On Tue, Nov 13, 2018 at 8:08 PM Aleksandar Markovic > > wrote: > > > > > > From: Aleksandar Markovic > > > > > > Disable R5900 support. Ther

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

2018-11-14 Thread Aleksandar Markovic
Philippe Mathieu-Daudé wrote: > Can you add: > > This reverts commit ed4f49ba9bb56ebca6987b1083255daf6c89b5de. > > Or > > Fixes: ed4f49ba9 > > when applying? Sure, I'll add something along that line. > If the issues you mentioned are "the R5900 tcg opcodes are not > implemented correctly",

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

2018-11-13 Thread Philippe Mathieu-Daudé
On Tue, Nov 13, 2018 at 8:29 PM Philippe Mathieu-Daudé wrote: > On Tue, Nov 13, 2018 at 8:08 PM Aleksandar Markovic > wrote: > > > > From: Aleksandar Markovic > > > > Disable R5900 support. There are some outstanding issues related > > to ABI support and emulation accuracy, that were not underst

Re: [Qemu-devel] [PATCH] target/mips: Disable R5900 support

2018-11-13 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On Tue, Nov 13, 2018 at 8:08 PM Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > Disable R5900 support. There are some outstanding issues related > to ABI support and emulation accuracy, that were not understood > well during review process. Disable to avoid backward c

[Qemu-devel] [PATCH] target/mips: Disable R5900 support

2018-11-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Disable R5900 support. There are some outstanding issues related to ABI support and emulation accuracy, that were not understood well during review process. Disable to avoid backward compatibility issues. Signed-off-by: Aleksandar Markovic --- target/mips/translate_in