On Wed, Nov 14, 2018 at 3:02 PM Aleksandar Markovic <amarko...@wavecomp.com> wrote: > Philippe Mathieu-Daudé <phili...@mathieu-daude.net> wrote: > > > Can you add: > > > > This reverts commit ed4f49ba9bb56ebca6987b1083255daf6c89b5de. > > > > Or > > > > Fixes: ed4f49ba9 > > > > when applying? > > Sure, I'll add something along that line. > > > If the issues you mentioned are "the R5900 tcg opcodes are not > > implemented correctly", then this patch is OK, because no cpu > > can use the R5900 opcodes. > > > > At some point while reading your reviews, I understood the R5900 > > patches introduced incorrect behaviors for the non-R5900 cpus. > > In this case this patch wouldn't suffice. > > This patch will be applied after the patches that Fredrik kindly > submitted under "Fix decoding..." series. Fredrik's patches will > remove any doubt about R5900 interfering other architectures, so, > as a consequence, this patch is sufficient and appropriate for > disabling R5900 support.
Ah OK, now it makes sens. > Additional clarification: This patch is to give more time for > all R5900 issues to be cleared in 3.1+ time frame. If R5900 code > was left enabled, we could have unpleasant backward compatibility > issues between R5900 support and different versions of QEMU. > > The R5900 support is intended to be enabled again when all issues > are resolved and agreed upon. The commit description is clear enough, this is what I understood from it :) Regards, Phil.
