Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-14 Thread Mike Day
On Wed, May 14, 2014 at 9:02 AM, Stefan Hajnoczi wrote: > Yes, we cannot change the git commit history once a commit is in the > public qemu.git repository. The only options are to: > > 1. Add a patch on top that fixes the issue. > 2. Use git-revert(1) to undo your commit entirely (this adds a ne

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-14 Thread Stefan Hajnoczi
On Wed, May 14, 2014 at 04:09:14PM +0800, Fam Zheng wrote: > On Wed, 05/14 09:50, Kevin Wolf wrote: > > Am 13.05.2014 um 18:07 hat Mike Day geschrieben: > > > The help message for qemu-img lists the supported block formats, of > > > which there are 27 as of version 2.0.50. The formats are printed i

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-14 Thread Fam Zheng
On Wed, 05/14 09:50, Kevin Wolf wrote: > Am 13.05.2014 um 18:07 hat Mike Day geschrieben: > > The help message for qemu-img lists the supported block formats, of > > which there are 27 as of version 2.0.50. The formats are printed in > > the order of their driver's position in a linked list, which

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-14 Thread Kevin Wolf
Am 13.05.2014 um 18:07 hat Mike Day geschrieben: > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > random. This patch prints the formats

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-13 Thread Markus Armbruster
Mike Day writes: > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > random. This patch prints the formats in sorted order, making it >

[Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-13 Thread Mike Day
The help message for qemu-img lists the supported block formats, of which there are 27 as of version 2.0.50. The formats are printed in the order of their driver's position in a linked list, which appears random. This patch prints the formats in sorted order, making it easier to read and to find a

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-05 Thread Mike Day
Thanks for the review! I've been able to shorten the next version quite a bit. On Mon, May 5, 2014 at 9:42 AM, Stefan Hajnoczi wrote: >> +static void GFunc_print_format(gpointer data, gpointer user) > > QEMU coding style is lowercase function and variable names. The > scripts/checkpatch.pl scri

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-05 Thread Stefan Hajnoczi
On Fri, May 02, 2014 at 09:11:15AM -0400, Mike Day wrote: > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > random. This patch prints th

[Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-02 Thread Mike Day
The help message for qemu-img lists the supported block formats, of which there are 27 as of version 2.0.50. The formats are printed in the order of their driver's position in a linked list, which appears random. This patch prints the formats in sorted order, making it easier to read and to find a