Mike Day <ncm...@ncultra.org> writes: > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > random. This patch prints the formats in sorted order, making it > easier to read and to find a specific format in the list.
Patch revision notes like these > [Added suggestions from Fam Zheng <f...@redhat.com> to declare variables > at the top of the scope in help() and to omit explicit cast for void* > opaque. > --Stefan] > > [Removed call to g_sequence_lookup because it breaks the build on > machines with glib < 2.28. > --Mike] > > Signed-off-by: Mike Day <ncm...@ncultra.org> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- ... go here, below the '---'. Furthermore, your previous patch went in already. We need an incremental patch to get rid of the dependency on non-ancient glib.