Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-27 Thread Markus Armbruster
Markus Armbruster writes: > "Michael S. Tsirkin" writes: > >> On Mon, Nov 03, 2014 at 05:13:15PM +0100, Markus Armbruster wrote: >>> "Michael S. Tsirkin" writes: >>> >>> > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >>> >> "Michael S. Tsirkin" writes: >>> >> >>> >> > t

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-04 Thread Michael S. Tsirkin
On Tue, Nov 04, 2014 at 12:17:29AM +, Peter Maydell wrote: > On 3 November 2014 16:35, Michael S. Tsirkin wrote: > > OK I backed that patch out and re-pushed. > > As other patches are unchanged, I don't want to re-do the pull > > request, it's just spam on list. > > > > Tag name is still for_u

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 03, 2014 at 05:13:15PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >> >> "Michael S. Tsirkin" writes: >> >> >> >> > tcp_get_fds API discards fds if there's

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Peter Maydell
On 3 November 2014 16:35, Michael S. Tsirkin wrote: > OK I backed that patch out and re-pushed. > As other patches are unchanged, I don't want to re-do the pull > request, it's just spam on list. > > Tag name is still for_upstream, new hash > d43f0d641e366251bd9c63005241775f672bf3ec OK, thanks; I

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 04:22:57PM +, Peter Maydell wrote: > On 3 November 2014 16:13, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > >> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" writes: > >>> > >>> > tcp_get_fds API discar

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 05:13:15PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > tcp_get_fds API discards fds if there's more than 1 of these. > >> > >> s/tcp

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > tcp_get_fds API discards fds if there's more than 1 of these. >> >> s/tcp_get_fds/tcp_get_msgfds/ (subject as well) > > Right. Too late as I sent this upstr

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 04:22:57PM +, Peter Maydell wrote: > On 3 November 2014 16:13, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > >> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: > >>> "Michael S. Tsirkin" writes: > >>> > >>> > tcp_get_fds API discar

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Peter Maydell
On 3 November 2014 16:13, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > >> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >>> "Michael S. Tsirkin" writes: >>> >>> > tcp_get_fds API discards fds if there's more than 1 of these. >>> >>> s/tcp_get_fds/tcp_get_msgfds/

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > tcp_get_fds API discards fds if there's more than 1 of these. >> >> s/tcp_get_fds/tcp_get_msgfds/ (subject as well) > > Right. Too late as I sent this upstr

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > tcp_get_fds API discards fds if there's more than 1 of these. > > s/tcp_get_fds/tcp_get_msgfds/ (subject as well) Right. Too late as I sent this upstream :( > What exactly doesn't work witho

Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-03 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > tcp_get_fds API discards fds if there's more than 1 of these. s/tcp_get_fds/tcp_get_msgfds/ (subject as well) What exactly doesn't work without this patch? > It's tricky to fix this without API changes in the generic case. > > However, this API is only used by te

[Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds

2014-11-02 Thread Michael S. Tsirkin
tcp_get_fds API discards fds if there's more than 1 of these. It's tricky to fix this without API changes in the generic case. However, this API is only used by tests ATM, and tests know how many fds they expect. So let's not waste cycles trying to fix this properly: simply assume at most 16 fds