Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

Applied to qapi-next.

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

On Thu, Jun 21, 2018 at 01:27:02PM +0200, Markus Armbruster wrote: > Forgot tests/qapi-schema/test-qapi.py, as usual. To be squashed in: > > diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py > index 4512a41504..abbc9c7830 100644 > --- a/tests/qapi-schema/test-qapi.py >

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

On Thu, Jun 21, 2018 at 01:23:47PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Jun 21, 2018 at 10:35:51AM +0200, Markus Armbruster wrote: > >> Fix the following issues: > >> > >> common.py:873:13: E129 visually indented line with same indent as next > >> logic

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

On 06/21/2018 05:35 AM, Markus Armbruster wrote: > Fix the following issues: > > common.py:873:13: E129 visually indented line with same indent as next > logical line > common.py:1766:5: E741 ambiguous variable name 'l' > common.py:1784:1: E305 expected 2 blank lines after class or fu

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

Forgot tests/qapi-schema/test-qapi.py, as usual. To be squashed in: diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index 4512a41504..abbc9c7830 100644 --- a/tests/qapi-schema/test-qapi.py +++ b/tests/qapi-schema/test-qapi.py @@ -33,8 +33,8 @@ class QAPISchemaTestVisi

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

Daniel P. Berrangé writes: > On Thu, Jun 21, 2018 at 10:35:51AM +0200, Markus Armbruster wrote: >> Fix the following issues: >> >> common.py:873:13: E129 visually indented line with same indent as next >> logical line >> common.py:1766:5: E741 ambiguous variable name 'l' >> common.p

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

On Thu, Jun 21, 2018 at 10:35:51AM +0200, Markus Armbruster wrote: > Fix the following issues: > > common.py:873:13: E129 visually indented line with same indent as next > logical line > common.py:1766:5: E741 ambiguous variable name 'l' > common.py:1784:1: E305 expected 2 blank lines

[Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

Fix the following issues: common.py:873:13: E129 visually indented line with same indent as next logical line common.py:1766:5: E741 ambiguous variable name 'l' common.py:1784:1: E305 expected 2 blank lines after class or function definition, found 1 common.py:1833:1: E305 expect