Re: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-20 Thread Kashyap Chamarthy
On Wed, Sep 19, 2018 at 01:46:37PM -0300, Eduardo Habkost wrote: > On Wed, Sep 19, 2018 at 12:22:19PM +0200, Kashyap Chamarthy wrote: > > On Tue, Sep 18, 2018 at 11:19:38AM -0300, Eduardo Habkost wrote: [...] > > Noted; shall I send a reworded patch to say: "This command will be > > deprecated in

Re: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Sep 19, 2018 at 12:22:19PM +0200, Kashyap Chamarthy wrote: >> On Tue, Sep 18, 2018 at 11:19:38AM -0300, Eduardo Habkost wrote: >> > On Tue, Sep 18, 2018 at 03:23:03PM +0200, Kashyap Chamarthy wrote: >> > > Eduardo Habkost mentioned on IRC that the intended functi

Re: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-19 Thread Eduardo Habkost
On Wed, Sep 19, 2018 at 12:22:19PM +0200, Kashyap Chamarthy wrote: > On Tue, Sep 18, 2018 at 11:19:38AM -0300, Eduardo Habkost wrote: > > On Tue, Sep 18, 2018 at 03:23:03PM +0200, Kashyap Chamarthy wrote: > > > Eduardo Habkost mentioned on IRC that the intended functionality of QMP > > > 'cpu-add'

Re: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-19 Thread Kashyap Chamarthy
On Tue, Sep 18, 2018 at 11:19:38AM -0300, Eduardo Habkost wrote: > On Tue, Sep 18, 2018 at 03:23:03PM +0200, Kashyap Chamarthy wrote: > > Eduardo Habkost mentioned on IRC that the intended functionality of QMP > > 'cpu-add' is replaced with a combination of 'query-hotpluggable-cpus' > > and 'device

Re: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-18 Thread Eduardo Habkost
On Tue, Sep 18, 2018 at 03:23:03PM +0200, Kashyap Chamarthy wrote: > Eduardo Habkost mentioned on IRC that the intended functionality of QMP > 'cpu-add' is replaced with a combination of 'query-hotpluggable-cpus' > and 'device_add'. And 'cpu-add' is likely to be deprecated in the > future. > > Ad

Re: [Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-18 Thread Kashyap Chamarthy
[...] If it looks OK to merge, when merging, please remove the needless word 'about': s/Clarify about/Clarify/ in the commit message summary line. -- /kashyap

[Qemu-devel] [PATCH] qapi/misc.json: Clarify about usage of QMP 'cpu-add'

2018-09-18 Thread Kashyap Chamarthy
Eduardo Habkost mentioned on IRC that the intended functionality of QMP 'cpu-add' is replaced with a combination of 'query-hotpluggable-cpus' and 'device_add'. And 'cpu-add' is likely to be deprecated in the future. Add a note in the QAPI schema to reflect that. Suggested-by: Eduardo Habkost --