On Wed, Sep 19, 2018 at 01:46:37PM -0300, Eduardo Habkost wrote: > On Wed, Sep 19, 2018 at 12:22:19PM +0200, Kashyap Chamarthy wrote: > > On Tue, Sep 18, 2018 at 11:19:38AM -0300, Eduardo Habkost wrote:
[...] > > Noted; shall I send a reworded patch to say: "This command will be > > deprecated in the near future"? > > I'd prefer a patch (against this file and qemu-deprecated.texi) > saying "this command is deprecated". Okay, I'll send a new patch (with commit summary line: "Deprecate QMP 'cpu-add'). > I don't see a reason to not deprecate the command immediately > (instead of just promising that it will be deprecated). Yeah, noted. [...] > > Yeah, to be clear, would you like me to amend the text in a different > > phrasing? Or is the current phrasing alright? Maybe needs an > > additional sentence about: "Refer the documentation of > > 'query-hotpluggable-cpus'"? > > I'd prefer a more succinct phrasing. e.g.: > > "This command is deprecated. The `device_add` command should > be used instead. See the `query-hotpluggable-cpus` command for > details." Sure. > The main problem is that the details I expected to see on the > documentation of `query-hotpluggable-cpus` aren't there. > > But before writing `query-hotpluggable-cpus` documentation from > scratch, I would like to find the answer to this: > > > > > > Igor, is the QMP documentation for query-hotpluggable-cpus the > > > only documentation we have on CPU hotplug? Yes, I'd also like to know the answer to that. -- /kashyap
