Re: [Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug

2019-09-02 Thread Kevin Wolf
Am 22.08.2019 um 15:38 hat Markus Armbruster geschrieben: > pr_manager_worker() passes its @opaque argument to g_free(). Wrong; > it points to pr_manager_worker()'s automatic @data. Broken when > commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix > by deleting the g_free(). >

Re: [Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug

2019-08-22 Thread Paolo Bonzini
On 22/08/19 15:38, Markus Armbruster wrote: > pr_manager_worker() passes its @opaque argument to g_free(). Wrong; > it points to pr_manager_worker()'s automatic @data. Broken when > commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix > by deleting the g_free(). > > Fixes: 2f3a

Re: [Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug

2019-08-22 Thread Philippe Mathieu-Daudé
On 8/22/19 3:38 PM, Markus Armbruster wrote: > pr_manager_worker() passes its @opaque argument to g_free(). Wrong; > it points to pr_manager_worker()'s automatic @data. Broken when > commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix > by deleting the g_free(). > > Fixes: 2f3

[Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug

2019-08-22 Thread Markus Armbruster
pr_manager_worker() passes its @opaque argument to g_free(). Wrong; it points to pr_manager_worker()'s automatic @data. Broken when commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix by deleting the g_free(). Fixes: 2f3a7ab39bec4ba8022dc4d42ea641165b004e3e Cc: qemu-sta...@non