On 22/08/19 15:38, Markus Armbruster wrote: > pr_manager_worker() passes its @opaque argument to g_free(). Wrong; > it points to pr_manager_worker()'s automatic @data. Broken when > commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix > by deleting the g_free(). > > Fixes: 2f3a7ab39bec4ba8022dc4d42ea641165b004e3e > Cc: qemu-sta...@nongnu.org > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > scsi/pr-manager.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scsi/pr-manager.c b/scsi/pr-manager.c > index ee43663576..0c866e8698 100644 > --- a/scsi/pr-manager.c > +++ b/scsi/pr-manager.c > @@ -39,7 +39,6 @@ static int pr_manager_worker(void *opaque) > int fd = data->fd; > int r; > > - g_free(data); > trace_pr_manager_run(fd, hdr->cmdp[0], hdr->cmdp[1]); > > /* The reference was taken in pr_manager_execute. */ >
Acked-by: Paolo Bonzini <pbonz...@redhat.com> Since I am disappearing soon, I wouldn't mind if the block layer people picked this up. Paolo
