Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-29 Thread Avi Kivity
On 08/29/2011 10:30 AM, Edgar E. Iglesias wrote: > > Forgot the branch: > > git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git fix-pflash That works Thanks for all the testing and help. I'll post the fixes for merging soon. -- I have a truly marvellous patch that fixes the bug which

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-29 Thread Edgar E. Iglesias
On Mon, Aug 29, 2011 at 10:21:03AM +0300, Avi Kivity wrote: > On 08/29/2011 09:15 AM, Avi Kivity wrote: > > On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote: > >> > > >> > It does bite, as I saw with gdb. You can even see that from the > >> > qemu error - it complains about unimplemented command

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-29 Thread Avi Kivity
On 08/29/2011 09:15 AM, Avi Kivity wrote: On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote: > > It does bite, as I saw with gdb. You can even see that from the > qemu error - it complains about unimplemented command 0xf0, that > comes from pflash_write() later on. I wasn't clear enough maybe

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Edgar E. Iglesias
On Mon, Aug 29, 2011 at 09:15:40AM +0300, Avi Kivity wrote: > On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote: > >> > >> It does bite, as I saw with gdb. You can even see that from the > >> qemu error - it complains about unimplemented command 0xf0, that > >> comes from pflash_write() later on.

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Avi Kivity
On 08/29/2011 09:00 AM, Edgar E. Iglesias wrote: > > It does bite, as I saw with gdb. You can even see that from the > qemu error - it complains about unimplemented command 0xf0, that > comes from pflash_write() later on. I wasn't clear enough maybe, the code in question is running, but the

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Edgar E. Iglesias
On Mon, Aug 29, 2011 at 08:36:14AM +0300, Avi Kivity wrote: > On 08/28/2011 10:33 PM, Edgar E. Iglesias wrote: > >On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > >> cfi02 is annoying in that is ignores some address bits; we probably > >> want explicit support in the memory API for t

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Edgar E. Iglesias
On Mon, Aug 29, 2011 at 08:36:14AM +0300, Avi Kivity wrote: > On 08/28/2011 10:33 PM, Edgar E. Iglesias wrote: > >On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > >> cfi02 is annoying in that is ignores some address bits; we probably > >> want explicit support in the memory API for t

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Edgar E. Iglesias
On Mon, Aug 29, 2011 at 08:38:26AM +0300, Avi Kivity wrote: > On 08/28/2011 11:37 PM, Edgar E. Iglesias wrote: > >On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > >> cfi02 is annoying in that is ignores some address bits; we probably > >> want explicit support in the memory API for t

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Avi Kivity
On 08/28/2011 11:37 PM, Edgar E. Iglesias wrote: On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. > > In order to get the correct opaque into the MemoryRegion ob

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Avi Kivity
On 08/28/2011 10:33 PM, Edgar E. Iglesias wrote: On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. > > In order to get the correct opaque into the MemoryRegion ob

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Avi Kivity
On 08/28/2011 09:14 PM, Edgar E. Iglesias wrote: On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. > > In order to get the correct opaque into the MemoryRegion ob

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Edgar E. Iglesias
On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. > > In order to get the correct opaque into the MemoryRegion object, the > allocation scheme is changed so that the

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Edgar E. Iglesias
On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. > > In order to get the correct opaque into the MemoryRegion object, the > allocation scheme is changed so that the

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Edgar E. Iglesias
On Sun, Aug 28, 2011 at 8:14 PM, Edgar E. Iglesias wrote: > On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > > cfi02 is annoying in that is ignores some address bits; we probably > > want explicit support in the memory API for that. > > > > In order to get the correct opaque into the

Re: [Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Edgar E. Iglesias
On Sun, Aug 28, 2011 at 06:43:36PM +0300, Avi Kivity wrote: > cfi02 is annoying in that is ignores some address bits; we probably > want explicit support in the memory API for that. > > In order to get the correct opaque into the MemoryRegion object, the > allocation scheme is changed so that the

[Qemu-devel] [PATCH] pflash_cfi01/pflash_cfi02: convert to memory API

2011-08-28 Thread Avi Kivity
cfi02 is annoying in that is ignores some address bits; we probably want explicit support in the memory API for that. In order to get the correct opaque into the MemoryRegion object, the allocation scheme is changed so that the flash emulation code allocates memory, instead of the caller. This cl