Re: [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits

2014-05-26 Thread Gerd Hoffmann
On Sa, 2014-05-24 at 11:02 +0400, Michael Tokarev wrote: > 24.05.2014 04:16, Andrew Oates wrote: > > Without the mask, control bits are passed on in the keycode, generating > > incorrect PS/2 sequences when SHIFT, ALT, etc are held down. > > While the patch itself appears to be trivial, it may hav

Re: [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits

2014-05-24 Thread Michael Tokarev
24.05.2014 04:16, Andrew Oates wrote: > Without the mask, control bits are passed on in the keycode, generating > incorrect PS/2 sequences when SHIFT, ALT, etc are held down. While the patch itself appears to be trivial, it may have non-trivial effect. Cc'ing Gerd for comments. Thank you! /mjt

[Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits

2014-05-23 Thread Andrew Oates
Without the mask, control bits are passed on in the keycode, generating incorrect PS/2 sequences when SHIFT, ALT, etc are held down. Signed-off-by: Andrew Oates --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index b044790..de85f7