On 11/09/2011 03:09 PM, Peter Maydell wrote:
"!X == 2" is always false (spotted by Coverity), so the checks
for whether rndis is in the correct state would never fire.
Signed-off-by: Peter Maydell
Applied. Thanks.
Regards,
Anthony Liguori
---
NB that although I tested that this doesn't br
On 14 November 2011 17:21, andrzej zaborowski wrote:
> On 14 November 2011 09:08, Peter Maydell wrote:
>> I'm happy that non-rndis works, I tested that. What I don't know
>> is whether the patch breaks rndis
>
> Sorry, I misread what you said assuming that you tested a branch
> affected by this p
On 14 November 2011 09:08, Peter Maydell wrote:
> I'm happy that non-rndis works, I tested that. What I don't know
> is whether the patch breaks rndis
Sorry, I misread what you said assuming that you tested a branch
affected by this patch. I'm unable to find a guest to test the rndis
mode so I r
On 14 November 2011 03:00, andrzej zaborowski wrote:
> On 9 November 2011 22:09, Peter Maydell wrote:
>> "!X == 2" is always false (spotted by Coverity), so the checks
>> for whether rndis is in the correct state would never fire.
>
> I pushed this patch because it's a bugfix and the check is gua
On 9 November 2011 22:09, Peter Maydell wrote:
> "!X == 2" is always false (spotted by Coverity), so the checks
> for whether rndis is in the correct state would never fire.
I pushed this patch because it's a bugfix and the check is guarded by
is_rndis() so there should be no risk of affecting no
"!X == 2" is always false (spotted by Coverity), so the checks
for whether rndis is in the correct state would never fire.
Signed-off-by: Peter Maydell
---
NB that although I tested that this doesn't break non-rndis
usb-net, I don't have a test image that uses rndis usb-net,
so treat this patch w
