On 14 November 2011 03:00, andrzej zaborowski <balr...@gmail.com> wrote: > On 9 November 2011 22:09, Peter Maydell <peter.mayd...@linaro.org> wrote: >> "!X == 2" is always false (spotted by Coverity), so the checks >> for whether rndis is in the correct state would never fire. > > I pushed this patch because it's a bugfix and the check is guarded by > is_rndis() so there should be no risk of affecting non-rndis.
I'm happy that non-rndis works, I tested that. What I don't know is whether the patch breaks rndis -- it's possible the checks were wrong all along but we never noticed because of this bug. That's why I suggested that somebody should test the rndis case before applying... -- PMM
