Re: [Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Peter Maydell
On 4 November 2013 20:38, Laszlo Ersek wrote: > On 11/04/13 21:07, Peter Maydell wrote: >> If this warning is going to complain about entirely >> safe and idiomatic code like >> >>int i; >>static const int some_array[] = { >>0x2a, 0x36, 0x1d, 0x9d, 0x38, 0xb8, 0xdb, 0xdd, >>};

Re: [Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Laszlo Ersek
On 11/04/13 21:07, Peter Maydell wrote: > On 4 November 2013 19:51, Stefan Weil wrote: >> With -Werror=sign-compare (not enabled by default), gcc shows these errors: >> >> ui/gtk.c: In function ‘gtk_release_modifiers’: >> ui/gtk.c:288:19: error: >> comparison between signed and unsigned integer e

Re: [Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Stefan Weil
Am 04.11.2013 21:07, schrieb Peter Maydell: > On 4 November 2013 19:51, Stefan Weil wrote: >> With -Werror=sign-compare (not enabled by default), gcc shows these errors: >> >> ui/gtk.c: In function ‘gtk_release_modifiers’: >> ui/gtk.c:288:19: error: >> comparison between signed and unsigned integ

Re: [Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Peter Maydell
On 4 November 2013 19:51, Stefan Weil wrote: > With -Werror=sign-compare (not enabled by default), gcc shows these errors: > > ui/gtk.c: In function ‘gtk_release_modifiers’: > ui/gtk.c:288:19: error: > comparison between signed and unsigned integer expressions > [-Werror=sign-compare] > ui/gtk.c

[Qemu-devel] [PATCH] gtk: Fix compiler warnings with -Werror=sign-compare

2013-11-04 Thread Stefan Weil
With -Werror=sign-compare (not enabled by default), gcc shows these errors: ui/gtk.c: In function ‘gtk_release_modifiers’: ui/gtk.c:288:19: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] ui/gtk.c: In function ‘gd_key_event’: ui/gtk.c:746:19: error: comp