On 4 November 2013 19:51, Stefan Weil <s...@weilnetz.de> wrote:
> With -Werror=sign-compare (not enabled by default), gcc shows these errors:
>
> ui/gtk.c: In function ‘gtk_release_modifiers’:
> ui/gtk.c:288:19: error:
> comparison between signed and unsigned integer expressions
> [-Werror=sign-compare]
> ui/gtk.c: In function ‘gd_key_event’:
> ui/gtk.c:746:19: error:
> comparison between signed and unsigned integer expressions
> [-Werror=sign-compare]
If this warning is going to complain about entirely
safe and idiomatic code like
int i;
static const int some_array[] = {
0x2a, 0x36, 0x1d, 0x9d, 0x38, 0xb8, 0xdb, 0xdd,
};
for (i = 0; i < ARRAY_SIZE(some_array); i++) {
...
}
then I think it is more trouble than it is worth and we
should leave it disabled.
thanks
-- PMM
