Re: [Qemu-devel] [PATCH] e1000: use alias for default model

2015-09-28 Thread Jason Wang
On 09/28/2015 04:57 PM, Markus Armbruster wrote: > Jason Wang writes: > >> Instead of using a new type for default model (82540em), using an >> alias for this to avoid bit duplication. > Suggest to rephrase as > > Instead of duplicating the "e1000-82540em" device model as "e1000", > make

Re: [Qemu-devel] [PATCH] e1000: use alias for default model

2015-09-28 Thread Markus Armbruster
Jason Wang writes: > Instead of using a new type for default model (82540em), using an > alias for this to avoid bit duplication. Suggest to rephrase as Instead of duplicating the "e1000-82540em" device model as "e1000", make the latter an alias for the former. > Cc: Markus Armbruster

[Qemu-devel] [PATCH] e1000: use alias for default model

2015-09-27 Thread Jason Wang
Instead of using a new type for default model (82540em), using an alias for this to avoid bit duplication. Cc: Markus Armbruster Signed-off-by: Jason Wang --- hw/net/e1000.c | 8 +--- qdev-monitor.c | 1 + 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/net/e1000.c b/hw/ne