Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Jan Kiszka
Aurelien Jarno wrote: > On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote: >> Aurelien Jarno wrote: >>> On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: From: Jan Kiszka Only match on true dir variable assignments, avoid generating garbage due to the "# Conf

Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Aurelien Jarno
On Sat, Jun 12, 2010 at 02:25:10PM +0200, Jan Kiszka wrote: > Aurelien Jarno wrote: > > On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> Only match on true dir variable assignments, avoid generating garbage > >> due to the "# Configured with: ..." line wh

Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Jan Kiszka
Aurelien Jarno wrote: > On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Only match on true dir variable assignments, avoid generating garbage >> due to the "# Configured with: ..." line which may contain "*dir=" as >> well. > > Wouldn't it be better to skip a

Re: [Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-12 Thread Aurelien Jarno
On Fri, Jun 11, 2010 at 10:58:29PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Only match on true dir variable assignments, avoid generating garbage > due to the "# Configured with: ..." line which may contain "*dir=" as > well. Wouldn't it be better to skip all lines starting with '#', as t

[Qemu-devel] [PATCH] configure: Fix evaluation of config-host.mak in create_config

2010-06-11 Thread Jan Kiszka
From: Jan Kiszka Only match on true dir variable assignments, avoid generating garbage due to the "# Configured with: ..." line which may contain "*dir=" as well. Signed-off-by: Jan Kiszka --- create_config |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/create_config