On 02/15/2018 04:08 AM, Daniel P. Berrangé wrote:
Hmm - here you're changing who supplies the (). But that argues that
maybe the callsites should supply " (" and ")" themselves.
Yeah, that's likely the saner way to do this. The question is: What
about the query-version QMP command? Should it
On Thu, Feb 15, 2018 at 07:02:40AM +0100, Thomas Huth wrote:
> On 14.02.2018 21:23, Eric Blake wrote:
> > On 02/14/2018 11:31 AM, Thomas Huth wrote:
> >> When running configure with --with-pkgversion=foo there is no
> >> space anymore between the version number and the parentheses:
> >>
> >> $ m68k
On 14.02.2018 21:23, Eric Blake wrote:
> On 02/14/2018 11:31 AM, Thomas Huth wrote:
>> When running configure with --with-pkgversion=foo there is no
>> space anymore between the version number and the parentheses:
>>
>> $ m68k-softmmu/qemu-system-m68k -version
>> QEMU emulator version 2.11.50(foo)
On 02/14/2018 11:31 AM, Thomas Huth wrote:
When running configure with --with-pkgversion=foo there is no
space anymore between the version number and the parentheses:
$ m68k-softmmu/qemu-system-m68k -version
QEMU emulator version 2.11.50(foo)
Fix it by moving the space from the configure script
On 02/14/2018 02:00 PM, Thomas Huth wrote:
On 14.02.2018 19:33, Peter Maydell wrote:
On 14 February 2018 at 17:31, Thomas Huth wrote:
When running configure with --with-pkgversion=foo there is no
space anymore between the version number and the parentheses:
$ m68k-softmmu/qemu-system-m68k -ve
On 14.02.2018 19:33, Peter Maydell wrote:
> On 14 February 2018 at 17:31, Thomas Huth wrote:
>> When running configure with --with-pkgversion=foo there is no
>> space anymore between the version number and the parentheses:
>>
>> $ m68k-softmmu/qemu-system-m68k -version
>> QEMU emulator version 2.1
On 14 February 2018 at 17:31, Thomas Huth wrote:
> When running configure with --with-pkgversion=foo there is no
> space anymore between the version number and the parentheses:
>
> $ m68k-softmmu/qemu-system-m68k -version
> QEMU emulator version 2.11.50(foo)
>
> Fix it by moving the space from the
When running configure with --with-pkgversion=foo there is no
space anymore between the version number and the parentheses:
$ m68k-softmmu/qemu-system-m68k -version
QEMU emulator version 2.11.50(foo)
Fix it by moving the space from the configure script to the Makefile.
Fixes: 67a1de0d195a6185c39
