On 14 February 2018 at 17:31, Thomas Huth <th...@redhat.com> wrote: > When running configure with --with-pkgversion=foo there is no > space anymore between the version number and the parentheses: > > $ m68k-softmmu/qemu-system-m68k -version > QEMU emulator version 2.11.50(foo) > > Fix it by moving the space from the configure script to the Makefile. > > Fixes: 67a1de0d195a6185c39b436159c9ffc7720bf979 > Buglink: https://bugs.launchpad.net/qemu/+bug/1673373 > Signed-off-by: Thomas Huth <th...@redhat.com>
I see that in the bug report I wrote "Also it looks like we return QEMU_PKGVERSION as part of the QMP qmp_query_version() code, so we should check to see what the expected behaviour there is regarding having the space or not." -- does this patch change the QMP reported string unexpectedly? thanks -- PMM