Nevermind, saw that updated comment in the later patch...
Thanks,
Darren.
On Mon, Dec 18, 2017 at 01:36:52PM +, Darren Kenny wrote:
Hi Paolo,
Slight nit on the subject line, did you mean to s/with/without/ -
that seems to reflect the change in the patch more correctly.
Thanks,
Darren.
Hi Paolo,
Slight nit on the subject line, did you mean to s/with/without/ -
that seems to reflect the change in the patch more correctly.
Thanks,
Darren.
On Mon, Dec 18, 2017 at 01:49:52PM +0100, Paolo Bonzini wrote:
On 15/12/2017 19:18, Marc-André Lureau wrote:
Instead of an error, lower to
On 18/12/2017 13:54, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 18, 2017 at 1:49 PM, Paolo Bonzini wrote:
>> On 15/12/2017 19:18, Marc-André Lureau wrote:
>>> Instead of an error, lower to a warning message, assuming the comment
>>> gives some justification.
>>>
>>> Discussed in:
>>> '[Qemu-de
Hi
On Mon, Dec 18, 2017 at 1:49 PM, Paolo Bonzini wrote:
> On 15/12/2017 19:18, Marc-André Lureau wrote:
>> Instead of an error, lower to a warning message, assuming the comment
>> gives some justification.
>>
>> Discussed in:
>> '[Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that
On 15/12/2017 19:18, Marc-André Lureau wrote:
> Instead of an error, lower to a warning message, assuming the comment
> gives some justification.
>
> Discussed in:
> '[Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that without a
> process to debug"'
>
> Suggested-by: Fam Zheng
> S
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20171215181810.4122-1-marcandre.lur...@redhat.com
Subject: [Qemu-devel] [PATCH] checkpatch: warn when using volatile with a
comment
=== TEST SCRIPT BEGIN ===
#!/bin/bash
Instead of an error, lower to a warning message, assuming the comment
gives some justification.
Discussed in:
'[Qemu-devel] [PATCH] dump-guest-memory.py: fix "You can't do that without a
process to debug"'
Suggested-by: Fam Zheng
Signed-off-by: Marc-André Lureau
---
scripts/checkpatch.pl | 7
