Re: [Qemu-devel] [PATCH] block: Drop bdrv_ioctl_bh_cb

2016-06-01 Thread Stefan Hajnoczi
On Wed, Jun 01, 2016 at 09:52:23AM +0800, Fam Zheng wrote: > Similar to the "!drv || !drv->bdrv_aio_ioctl" case above, here it is > okay to set co.ret and return. As pointed out by Paolo, a BH will be > created as necessary by the caller (bdrv_co_maybe_schedule_bh). > Besides, as pointed out by Kev

Re: [Qemu-devel] [PATCH] block: Drop bdrv_ioctl_bh_cb

2016-06-01 Thread Paolo Bonzini
On 01/06/2016 03:52, Fam Zheng wrote: > Similar to the "!drv || !drv->bdrv_aio_ioctl" case above, here it is > okay to set co.ret and return. As pointed out by Paolo, a BH will be > created as necessary by the caller (bdrv_co_maybe_schedule_bh). > Besides, as pointed out by Kevin, "data" was leak

[Qemu-devel] [PATCH] block: Drop bdrv_ioctl_bh_cb

2016-05-31 Thread Fam Zheng
Similar to the "!drv || !drv->bdrv_aio_ioctl" case above, here it is okay to set co.ret and return. As pointed out by Paolo, a BH will be created as necessary by the caller (bdrv_co_maybe_schedule_bh). Besides, as pointed out by Kevin, "data" was leaked before. Reported-by: Kevin Wolf Reported-by