On Thu, Dec 31, 2009 at 01:01:50PM -0600, Anthony Liguori wrote:
> On 12/31/2009 09:39 AM, Gleb Natapov wrote:
> >>The common case is where you just want to see the state of the
> >>device. We support hundreds of devices. We can have one code path
> >>that displays 95% of them with a couple device
On Thu, Dec 31, 2009 at 12:57:44PM -0600, Anthony Liguori wrote:
> On 12/31/2009 09:33 AM, Gleb Natapov wrote:
> >On Thu, Dec 31, 2009 at 08:15:29AM -0600, Anthony Liguori wrote:
> >>On 12/30/2009 06:16 PM, Gleb Natapov wrote:
> >>>It helps debug problems and it is not intrusive. Since 0.12 will be
On 12/31/2009 09:39 AM, Gleb Natapov wrote:
The common case is where you just want to see the state of the
device. We support hundreds of devices. We can have one code path
that displays 95% of them with a couple devices that have exceptions
or we could have hundreds of these commands that aren'
On 12/31/2009 09:33 AM, Gleb Natapov wrote:
On Thu, Dec 31, 2009 at 08:15:29AM -0600, Anthony Liguori wrote:
On 12/30/2009 06:16 PM, Gleb Natapov wrote:
It helps debug problems and it is not intrusive. Since 0.12 will be used
for a long time I want to add it there for convenience.
stable is f
On Thu, Dec 31, 2009 at 08:18:40AM -0600, Anthony Liguori wrote:
> On 12/31/2009 12:38 AM, Avi Kivity wrote:
> >On 12/31/2009 12:46 AM, Anthony Liguori wrote:
> >>>I wasn't worried about that, only the increased code duplication.
> >>
> >>
> >>I wasn't thinking there would be an info ioapic command
On Thu, Dec 31, 2009 at 08:15:29AM -0600, Anthony Liguori wrote:
> On 12/30/2009 06:16 PM, Gleb Natapov wrote:
> >It helps debug problems and it is not intrusive. Since 0.12 will be used
> >for a long time I want to add it there for convenience.
>
> stable is for bug fixes only.
>
This is to clos
On 12/31/2009 12:38 AM, Avi Kivity wrote:
On 12/31/2009 12:46 AM, Anthony Liguori wrote:
I wasn't worried about that, only the increased code duplication.
I wasn't thinking there would be an info ioapic command but rather a
generic device-info command that would work with any qdev device. No
On 12/30/2009 06:16 PM, Gleb Natapov wrote:
It helps debug problems and it is not intrusive. Since 0.12 will be used
for a long time I want to add it there for convenience.
stable is for bug fixes only.
Regards,
Anthony Liguori
--
Gleb.
On 12/30/2009 06:14 PM, Gleb Natapov wrote:
No we don't. You want to add the infrastructure to do it right and I
have no problem with that go add it. But till then we do it old way.
We have the infrastructure today to do it the right way.
Regards,
Anthony Liguori
--
On 12/31/2009 12:46 AM, Anthony Liguori wrote:
I wasn't worried about that, only the increased code duplication.
I wasn't thinking there would be an info ioapic command but rather a
generic device-info command that would work with any qdev device. No
code duplication (in fact, much, much le
On Wed, Dec 30, 2009 at 04:47:45PM -0600, Anthony Liguori wrote:
> On 12/30/2009 08:30 AM, Gleb Natapov wrote:
> >On Wed, Dec 30, 2009 at 04:26:11PM +0200, Gleb Natapov wrote:
> >>On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote:
> >>>On 12/30/2009 03:27 AM, Gleb Natapov wrote:
> >>>
On Wed, Dec 30, 2009 at 04:49:01PM -0600, Anthony Liguori wrote:
> On 12/30/2009 08:26 AM, Gleb Natapov wrote:
> >On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote:
> >>On 12/30/2009 03:27 AM, Gleb Natapov wrote:
> >>>On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote:
>
On 12/30/2009 08:26 AM, Gleb Natapov wrote:
On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote:
On 12/30/2009 03:27 AM, Gleb Natapov wrote:
On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote:
On 12/24/2009 09:02 AM, Gleb Natapov wrote:
Knowing ioapic configuration is
On 12/30/2009 08:30 AM, Gleb Natapov wrote:
On Wed, Dec 30, 2009 at 04:26:11PM +0200, Gleb Natapov wrote:
On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote:
On 12/30/2009 03:27 AM, Gleb Natapov wrote:
On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote:
On 12/24/2009
On 12/30/2009 08:19 AM, Avi Kivity wrote:
On 12/30/2009 04:17 PM, Anthony Liguori wrote:
That's a good idea, but it would mean that we'd need into ioapic and
info ioapic-kvm if we go for a split implementation.
I don't think that's a problem. A developer will be smart enough to
know that they
On Wed, Dec 30, 2009 at 04:26:11PM +0200, Gleb Natapov wrote:
> On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote:
> > On 12/30/2009 03:27 AM, Gleb Natapov wrote:
> > >On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote:
> > >>On 12/24/2009 09:02 AM, Gleb Natapov wrote:
>
On Wed, Dec 30, 2009 at 08:16:30AM -0600, Anthony Liguori wrote:
> On 12/30/2009 03:27 AM, Gleb Natapov wrote:
> >On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote:
> >>On 12/24/2009 09:02 AM, Gleb Natapov wrote:
> >>>Knowing ioapic configuration is very useful for the poor soles
> >>
On 12/30/2009 04:17 PM, Anthony Liguori wrote:
That's a good idea, but it would mean that we'd need into ioapic and
info ioapic-kvm if we go for a split implementation.
I don't think that's a problem. A developer will be smart enough to
know that they need to do that (and will get an error
On 12/30/2009 12:53 AM, Avi Kivity wrote:
On 12/30/2009 04:00 AM, Anthony Liguori wrote:
On 12/24/2009 09:02 AM, Gleb Natapov wrote:
Knowing ioapic configuration is very useful for the poor soles
how need to debug guest occasionally.
Can this be implemented in terms of VMState?
That's a go
On 12/30/2009 03:27 AM, Gleb Natapov wrote:
On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote:
On 12/24/2009 09:02 AM, Gleb Natapov wrote:
Knowing ioapic configuration is very useful for the poor soles
how need to debug guest occasionally.
Can this be implemented in terms of VMS
On Wed, 30 Dec 2009 12:45:08 +0200
Gleb Natapov wrote:
> On Tue, Dec 29, 2009 at 06:49:14PM -0200, Luiz Capitulino wrote:
> > On Tue, 29 Dec 2009 20:49:53 +0200
> > Gleb Natapov wrote:
> >
> > > On Tue, Dec 29, 2009 at 03:39:29PM -0200, Luiz Capitulino wrote:
> > > > On Tue, 29 Dec 2009 18:53:4
On Tue, Dec 29, 2009 at 06:49:14PM -0200, Luiz Capitulino wrote:
> On Tue, 29 Dec 2009 20:49:53 +0200
> Gleb Natapov wrote:
>
> > On Tue, Dec 29, 2009 at 03:39:29PM -0200, Luiz Capitulino wrote:
> > > On Tue, 29 Dec 2009 18:53:44 +0200
> > > Gleb Natapov wrote:
> > >
> > > > On Tue, Dec 29, 200
On Tue, Dec 29, 2009 at 08:00:09PM -0600, Anthony Liguori wrote:
> On 12/24/2009 09:02 AM, Gleb Natapov wrote:
> >Knowing ioapic configuration is very useful for the poor soles
> >how need to debug guest occasionally.
>
> Can this be implemented in terms of VMState?
>
What do you mean and why it
On 12/30/2009 04:00 AM, Anthony Liguori wrote:
On 12/24/2009 09:02 AM, Gleb Natapov wrote:
Knowing ioapic configuration is very useful for the poor soles
how need to debug guest occasionally.
Can this be implemented in terms of VMState?
That's a good idea, but it would mean that we'd need i
On 12/24/2009 09:02 AM, Gleb Natapov wrote:
Knowing ioapic configuration is very useful for the poor soles
how need to debug guest occasionally.
Can this be implemented in terms of VMState?
Regards,
Anthony Liguori
On Tue, 29 Dec 2009 20:49:53 +0200
Gleb Natapov wrote:
> On Tue, Dec 29, 2009 at 03:39:29PM -0200, Luiz Capitulino wrote:
> > On Tue, 29 Dec 2009 18:53:44 +0200
> > Gleb Natapov wrote:
> >
> > > On Tue, Dec 29, 2009 at 02:37:20PM -0200, Luiz Capitulino wrote:
> > > > On Thu, 24 Dec 2009 17:02:4
On Tue, Dec 29, 2009 at 03:39:29PM -0200, Luiz Capitulino wrote:
> On Tue, 29 Dec 2009 18:53:44 +0200
> Gleb Natapov wrote:
>
> > On Tue, Dec 29, 2009 at 02:37:20PM -0200, Luiz Capitulino wrote:
> > > On Thu, 24 Dec 2009 17:02:42 +0200
> > > Gleb Natapov wrote:
> > >
> > > > +
> > > > +static c
On Tue, 29 Dec 2009 18:53:44 +0200
Gleb Natapov wrote:
> On Tue, Dec 29, 2009 at 02:37:20PM -0200, Luiz Capitulino wrote:
> > On Thu, 24 Dec 2009 17:02:42 +0200
> > Gleb Natapov wrote:
> >
> > > +
> > > +static const char *delivery_mode_string[] = {"fixed", "lowprio", "smi",
> > > "res",
> > >
On Tue, Dec 29, 2009 at 02:37:20PM -0200, Luiz Capitulino wrote:
> On Thu, 24 Dec 2009 17:02:42 +0200
> Gleb Natapov wrote:
>
> > +
> > +static const char *delivery_mode_string[] = {"fixed", "lowprio", "smi",
> > "res",
> > + "nmi", "init", "res",
> >
On Thu, 24 Dec 2009 17:02:42 +0200
Gleb Natapov wrote:
> +
> +static const char *delivery_mode_string[] = {"fixed", "lowprio", "smi",
> "res",
> + "nmi", "init", "res", "extint"};
> +
> +void do_info_ioapic(Monitor *mon)
> +{
> +int i;
> +
> +i
Knowing ioapic configuration is very useful for the poor soles
how need to debug guest occasionally.
Signed-off-by: Gleb Natapov
diff --git a/hw/ioapic.c b/hw/ioapic.c
index b0ad78f..ffbe631 100644
--- a/hw/ioapic.c
+++ b/hw/ioapic.c
@@ -24,6 +24,7 @@
#include "pc.h"
#include "qemu-timer.h"
#i
31 matches
Mail list logo
