Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server

2012-06-27 Thread Anthony Liguori
On 06/20/2012 08:24 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" QEMU now has a fundamental requirement for pthreads, so there is no compelling reason to retain support for the non-threaded VNC server. Remove the --{enable,disable}-vnc-thread configure arguments, and all CONFIG_VNC_T

Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server

2012-06-21 Thread Gerd Hoffmann
On 06/21/12 11:59, Daniel P. Berrange wrote: > On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote: >> 20.06.2012 16:24, Daniel P. Berrange wrote: >>> delete mode 100644 ui/vnc-jobs-async.c >>> delete mode 100644 ui/vnc-jobs-sync.c >>> create mode 100644 ui/vnc-jobs.c >> >> Is there

Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server

2012-06-21 Thread Daniel P. Berrange
On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote: > 20.06.2012 16:24, Daniel P. Berrange wrote: > > delete mode 100644 ui/vnc-jobs-async.c > > delete mode 100644 ui/vnc-jobs-sync.c > > create mode 100644 ui/vnc-jobs.c > > Is there a reason to rename vnc-jobs-foo.c to vnc-jobs.c ?

Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server

2012-06-21 Thread Michael Tokarev
20.06.2012 16:24, Daniel P. Berrange wrote: delete mode 100644 ui/vnc-jobs-async.c delete mode 100644 ui/vnc-jobs-sync.c create mode 100644 ui/vnc-jobs.c Is there a reason to rename vnc-jobs-foo.c to vnc-jobs.c ? I'd leave it alone at this stage, omiting just the rename... /mjt

[Qemu-devel] [PATCH] Remove support for non-threaded VNC server

2012-06-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" QEMU now has a fundamental requirement for pthreads, so there is no compelling reason to retain support for the non-threaded VNC server. Remove the --{enable,disable}-vnc-thread configure arguments, and all CONFIG_VNC_THREAD conditionals Signed-off-by: Daniel P. Berran