Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Maciej W. Rozycki
Hi Andreas, > > I find quilt patches easier to manage when I need to reorder them, > > revert, manually edit the diffs (that I routinely do), etc. Perhaps I'm > > just outdated, but that's the workflow I've found most efficient for me > > while not disturbing anyone else. I've used quilt pat

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Meador Inge
On 08/10/2012 09:30 AM, Andreas Färber wrote: > OK, so you didn't retract them but Meador did comment: > >> > I submitted a patch to fix this issue and the FCR0 issue a few months back >> > [1]. >> > Andreas reviewed it, but the patch never got committed. >> > >> > [1] http://patchwork.ozlabs.o

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Andreas Färber
Hello Maciej, Am 10.08.2012 15:15, schrieb Maciej W. Rozycki: Actually there were better patches for the same bug by Meador, including git-style rather than SVN patches and adding a helper to initialize it consistently at all call sites. > > I find quilt patches easier to manage w

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Maciej W. Rozycki
Andreas, > >> Actually there were better patches for the same bug by Meador, including > >> git-style rather than SVN patches and adding a helper to initialize it > >> consistently at all call sites. I find quilt patches easier to manage when I need to reorder them, revert, manually edit the di

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Andreas Färber
Am 10.08.2012 11:00, schrieb Peter Maydell: > On 10 August 2012 09:48, Andreas Färber wrote: >> Actually there were better patches for the same bug by Meador, including >> git-style rather than SVN patches and adding a helper to initialize it >> consistently at all call sites. >> >> There's also D

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Peter Maydell
On 10 August 2012 09:48, Andreas Färber wrote: > Am 09.08.2012 22:36, schrieb Peter Maydell: >> Maciej submitted some other MIPS patches at about the same time: >> http://patchwork.ozlabs.org/project/qemu-devel/list/?submitter=4977 >> at least some of which got reviewed by Richard Henderson and ar

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-10 Thread Andreas Färber
Am 09.08.2012 22:36, schrieb Peter Maydell: > On 9 August 2012 21:01, Phil Staub wrote: >> On 08/09/2012 12:57 PM, Blue Swirl wrote: >>> On Tue, Aug 7, 2012 at 12:10 PM, Peter Maydell >>> wrote: For this purpose the usual approach is to follow up to the patch mail saying "Ping" and givi

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-09 Thread Phil Staub
On 08/09/2012 03:09 PM, Maciej W. Rozycki wrote: On Thu, 9 Aug 2012, Phil Staub wrote: For this purpose the usual approach is to follow up to the patch mail saying "Ping" and giving a url to the patch in patchwork, like this one: http://patchwork.ozlabs.org/patch/163705/ Eventually somebody wi

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-09 Thread Maciej W. Rozycki
On Thu, 9 Aug 2012, Phil Staub wrote: > > > > > For this purpose the usual approach is to follow up to the patch > > > > > mail saying "Ping" and giving a url to the patch in patchwork, > > > > > like this one: > > > > > http://patchwork.ozlabs.org/patch/163705/ > > > > > > > > > > Eventually som

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-09 Thread Phil Staub
On 08/09/2012 01:36 PM, Peter Maydell wrote: On 9 August 2012 21:01, Phil Staub wrote: On 08/09/2012 12:57 PM, Blue Swirl wrote: On Tue, Aug 7, 2012 at 12:10 PM, Peter Maydell wrote: For this purpose the usual approach is to follow up to the patch mail saying "Ping" and giving a url to the p

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-09 Thread Peter Maydell
On 9 August 2012 21:01, Phil Staub wrote: > On 08/09/2012 12:57 PM, Blue Swirl wrote: >> On Tue, Aug 7, 2012 at 12:10 PM, Peter Maydell >> wrote: >>> For this purpose the usual approach is to follow up to the patch >>> mail saying "Ping" and giving a url to the patch in patchwork, >>> like this o

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-09 Thread Phil Staub
On 08/09/2012 12:57 PM, Blue Swirl wrote: On Tue, Aug 7, 2012 at 12:10 PM, Peter Maydell wrote: On 6 August 2012 19:21, Phil Staub wrote: On Tue, Jun 12, 2012 at 10:28:14AM -0400, qemu-devel-requ...@nongnu.org wrote: From: Richard Henderson On 2012-06-07 18:04, Maciej W. Rozycki wrote: I

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-09 Thread Blue Swirl
On Tue, Aug 7, 2012 at 12:10 PM, Peter Maydell wrote: > On 6 August 2012 19:21, Phil Staub wrote: >> On Tue, Jun 12, 2012 at 10:28:14AM -0400, qemu-devel-requ...@nongnu.org >> wrote: >>> From: Richard Henderson >>> On 2012-06-07 18:04, Maciej W. Rozycki wrote: >>> > I have verified this change

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-07 Thread Phil Staub
On 08/07/2012 05:10 AM, Peter Maydell wrote: On 6 August 2012 19:21, Phil Staub wrote: On Tue, Jun 12, 2012 at 10:28:14AM -0400, qemu-devel-requ...@nongnu.org wrote: From: Richard Henderson On 2012-06-07 18:04, Maciej W. Rozycki wrote: I have verified this change with system emulation runn

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-07 Thread Peter Maydell
On 6 August 2012 19:21, Phil Staub wrote: > On Tue, Jun 12, 2012 at 10:28:14AM -0400, qemu-devel-requ...@nongnu.org wrote: >> From: Richard Henderson >> On 2012-06-07 18:04, Maciej W. Rozycki wrote: >> > I have verified this change with system emulation running the GDB test >> > suite for the mi

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-06 Thread Phil Staub
On Tue, Jun 12, 2012 at 10:28:14AM -0400, qemu-devel-requ...@nongnu.org wrote: > Date: Tue, 12 Jun 2012 07:14:45 -0700 > From: Richard Henderson > To: "Maciej W. Rozycki" > Cc: qemu-devel@nongnu.org, Aurelien Jarno > Subject: Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-06-12 Thread Richard Henderson
On 2012-06-07 18:04, Maciej W. Rozycki wrote: > I have verified this change with system emulation running the GDB test > suite for the mips-sde-elf target (o32, big endian, 24Kf CPU emulated), > there were 55 progressions and no regressions. > > Signed-off-by: Maciej W. Rozycki > --- > > Sen

[Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-06-07 Thread Maciej W. Rozycki
From: Nathan Froyd This change addresses a problem where QEMU incorrectly traps on floating-point MADD group instructions with SIGILL, at least while emulating MIPS32r2 processors. These instructions use the COP1X major opcode and include ones like: madd.d $f2,$f4,$f2,$f6 Here's