Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

2013-01-02 Thread Peter Maydell
On 2 January 2013 14:34, Samuel Seay wrote: > I did not catch that, somehow I managed to invert the logic when looking at > it. Maybe a g2h() (such a macro exist? what would be the proper method?) > around the newsp value would do it. You want to use put_user() (without the __) -- this (a) takes

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

2013-01-02 Thread Samuel Seay
I did not catch that, somehow I managed to invert the logic when looking at it. Maybe a g2h() (such a macro exist? what would be the proper method?) around the newsp value would do it. I'll redo that this evening and attempt to submit a newer patch. Considering I don't have direct internet access i

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

2013-01-02 Thread Peter Maydell
On 2 January 2013 13:01, Samuel Seay wrote: > The VM I did the work in doesn't have internet access and I was unsure how > to do a text only email with gmail. With that said, the line that removed > the env->gpr[1] is redudant as a few lines below in the original source it > is set with newsp. The

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

2013-01-02 Thread Samuel Seay
The VM I did the work in doesn't have internet access and I was unsure how to do a text only email with gmail. With that said, the line that removed the env->gpr[1] is redudant as a few lines below in the original source it is set with newsp. The removed line would seg fault due to trying to write

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

2013-01-02 Thread Peter Maydell
On 2 January 2013 04:58, Samuel Seay wrote: > Attached is a patch for fixing bug #1052857. My local tests show it working > properly on 32 and 64bit. --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -4584,7 +4584,7 @@ static void setup_frame(int sig, struct target_sigaction *ka, signa

Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

2013-01-02 Thread Andreas Färber
Hello, Am 02.01.2013 05:58, schrieb Samuel Seay: > Attached is a patch for fixing bug #1052857. My local tests show it > working properly on 32 and 64bit. > > Signed-off-by: Samuel Seay > Please submit patches using git-send-email tool so that they arrive text-only

[Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

2013-01-01 Thread Samuel Seay
Attached is a patch for fixing bug #1052857. My local tests show it working properly on 32 and 64bit. Signed-off-by: Samuel Seay 0001-Change-to-correct-PowerPC-on-64bit-host.patch Description: Binary data