On Fri, May 6, 2016 at 2:05 PM, Kevin Wolf wrote:
>>
>> Reviewed-by: Fam Zheng
>
> Thanks, applied to block-next.
Great, thanks everyone!
--
Janne
Am 06.05.2016 um 11:04 hat Fam Zheng geschrieben:
> On Tue, 05/03 02:43, Janne Karhunen wrote:
> > From: Janne Karhunen
> >
> > Vmdk images have metadata to indicate the vmware virtual
> > hardware version image was created/tested to run with.
> > Allow users to specify that version via new 'hwve
On Fri, 05/06 08:15, Janne Karhunen wrote:
> Fam,
>
> Any objections to this one?
Looks good to me. I've left my reviewed-by in direct reply to the patch. Cc'ing
block layer maintainers and qemu-block list.
Fam
On Tue, 05/03 02:43, Janne Karhunen wrote:
> From: Janne Karhunen
>
> Vmdk images have metadata to indicate the vmware virtual
> hardware version image was created/tested to run with.
> Allow users to specify that version via new 'hwversion'
> option.
>
> Signed-off-by: Janne Karhunen
> ---
>
Fam,
Any objections to this one?
--
Janne
On Tue, May 3, 2016 at 12:43 PM, Janne Karhunen
wrote:
> From: Janne Karhunen
>
> Vmdk images have metadata to indicate the vmware virtual
> hardware version image was created/tested to run with.
> Allow users to specify that version via new 'hwversio
On Mon, May 2, 2016 at 5:49 PM, Fam Zheng wrote:
> Yes.
>
> But you get:
Fair enough, sent another one.
Thanks,
--
Janne
From: Janne Karhunen
Vmdk images have metadata to indicate the vmware virtual
hardware version image was created/tested to run with.
Allow users to specify that version via new 'hwversion'
option.
Signed-off-by: Janne Karhunen
---
block/vmdk.c | 27 +++
inc
On Mon, 05/02 04:30, Janne Karhunen wrote:
> >> if (qemu_opt_get_bool_del(opts, BLOCK_OPT_COMPAT6, false)) {
> >> -flags |= BLOCK_FLAG_COMPAT6;
> >
> > Please remove BLOCK_FLAG_COMPAT6 from include/block/block_int.h| as well.
>
> Wasn't it removed?
>
> -#define BLOCK_FLAG_COMPAT6
On Fri, Apr 29, 2016 at 12:41 AM, Fam Zheng wrote:
>> Signed-off-by: Janne Karhunen
>
> Sorry for the late reply, I was distracted..
Like wise, was traveling..
>> if (qemu_opt_get_bool_del(opts, BLOCK_OPT_COMPAT6, false)) {
>> -flags |= BLOCK_FLAG_COMPAT6;
>
> Please remove BLOCK
On Thu, 04/21 12:29, Janne Karhunen wrote:
> From: Janne Karhunen
>
> Vmdk images have metadata to indicate the vmware virtual
> hardware version image was created/tested to run with.
> Allow users to specify that version via new 'hwversion'
> option.
>
> Signed-off-by: Janne Karhunen
Sorry fo
On Fri, 04/22 08:23, Janne Karhunen wrote:
> On Wed, Apr 20, 2016 at 9:44 PM, Fam Zheng wrote:
>
> >> That's certainly doable and kind of makes sense, but I'm not entirely
> >> sure that compat6 flag makes any sense to begin with. Does it?
> >
> > I don't know VMware products well enough to tell,
On Wed, Apr 20, 2016 at 9:44 PM, Fam Zheng wrote:
>> That's certainly doable and kind of makes sense, but I'm not entirely
>> sure that compat6 flag makes any sense to begin with. Does it?
>
> I don't know VMware products well enough to tell, but it has been available
> since forever, therefore m
From: Janne Karhunen
Vmdk images have metadata to indicate the vmware virtual
hardware version image was created/tested to run with.
Allow users to specify that version via new 'hwversion'
option.
Signed-off-by: Janne Karhunen
---
block/vmdk.c | 23 +++
include
On Wed, 04/20 20:22, Janne Karhunen wrote:
> On Wed, Apr 20, 2016 at 7:22 PM, Fam Zheng wrote:
>
> > For backward compatibility reason, we shouldn't remove a pre-existing option
> > without solid justification and probably a grace period. I suggest adding
> > the
> > hwversion option in addition
On Wed, Apr 20, 2016 at 8:26 PM, Fam Zheng wrote:
>> In other words, without the patch not a single qemu-img generated vmdk
>> is 'good' for the system I'm using.
>
> Thanks for the explanation, please add this information into the commit
> message
> in next submission and also fix the option co
On Wed, 04/20 20:02, Janne Karhunen wrote:
> On Wed, Apr 20, 2016 at 7:22 PM, Fam Zheng wrote:
>
> >> Replace hardcoded vmdk description file hardware version flag with
> >> a user definable version.
> >
> > Hi Janne,
> >
> > Since this is a new feature, please explain why this change is desired
On Wed, Apr 20, 2016 at 7:22 PM, Fam Zheng wrote:
> For backward compatibility reason, we shouldn't remove a pre-existing option
> without solid justification and probably a grace period. I suggest adding the
> hwversion option in addition, and document and check it as exclusive with the
> compat
On Wed, Apr 20, 2016 at 7:22 PM, Fam Zheng wrote:
>> Replace hardcoded vmdk description file hardware version flag with
>> a user definable version.
>
> Hi Janne,
>
> Since this is a new feature, please explain why this change is desired (i.e.
> the necessity.)
See here what it controls for vmwa
On Wed, 04/20 15:27, Janne Karhunen wrote:
> From: Janne Karhunen
>
> Replace hardcoded vmdk description file hardware version flag with
> a user definable version.
Hi Janne,
Since this is a new feature, please explain why this change is desired (i.e.
the necessity.)
>
> Signed-off-by: Janne
From: Janne Karhunen
Replace hardcoded vmdk description file hardware version flag with
a user definable version.
Signed-off-by: Janne Karhunen
---
block/vmdk.c | 20 ++--
include/block/block_int.h | 3 +--
qemu-doc.texi | 4 ++--
3 files changed, 13
20 matches
Mail list logo
