On Wed, Apr 20, 2016 at 7:22 PM, Fam Zheng <f...@redhat.com> wrote: >> Replace hardcoded vmdk description file hardware version flag with >> a user definable version. > > Hi Janne, > > Since this is a new feature, please explain why this change is desired (i.e. > the necessity.)
See here what it controls for vmware: https://kb.vmware.com/selfservice/microsites/search.do?languag e=en_US&cmd=displayKC&externalId=1003746 Seems that the vmware cluster I'm using is configured to eat vmdks with only certain virtual hardware versions specified as being supported, so this patch allows me to define that version. Besides that, I've read that to mean that it's a hint from me (as the vmdk author) to the cluster that this is the vmware virtual hardware version I have tested this vmdk to run with. It's actually relatively useful metadata as such. In other words, without the patch not a single qemu-img generated vmdk is 'good' for the system I'm using. -- Janne
