On Thu, Sep 1, 2011 at 9:49 PM, Anthony Liguori wrote:
> On 09/01/2011 02:39 AM, Markus Armbruster wrote:
>>
>> Blue Swirl writes:
>>
>>> On Wed, Aug 31, 2011 at 4:06 PM, Anthony Liguori
>>> wrote:
On 08/31/2011 09:35 AM, malc wrote:
>
> On Wed, 31 Aug 2011, Anthony Liguori wro
On 09/01/2011 02:39 AM, Markus Armbruster wrote:
Blue Swirl writes:
On Wed, Aug 31, 2011 at 4:06 PM, Anthony Liguori wrote:
On 08/31/2011 09:35 AM, malc wrote:
On Wed, 31 Aug 2011, Anthony Liguori wrote:
Upper case field names are not okay. If you think coding style isn't
clear,
that's
--- On Thu, 1/9/11, Avi Kivity wrote:
> On 08/31/2011 04:05 AM, bifferos
> wrote:
> > + pci_register_bar(&s->dev, 0,
> 0x100, PCI_BASE_ADDRESS_SPACE_IO, r6040_map);
> pci_register_bar() has been converted to the memory
> API. Please rebase to the latest qemu.git master and
> read docs/memory.
On 08/31/11 18:06, Anthony Liguori wrote:
On 08/31/2011 09:35 AM, malc wrote:
On Wed, 31 Aug 2011, Anthony Liguori wrote:
Upper case field names are not okay. If you think coding style isn't
clear,
that's a bug in coding style.
There's no benefit to going through and changing existing code
On 08/31/2011 04:05 AM, bifferos wrote:
+pci_register_bar(&s->dev, 0, 0x100, PCI_BASE_ADDRESS_SPACE_IO, r6040_map);
+
pci_register_bar() has been converted to the memory API. Please rebase
to the latest qemu.git master and read docs/memory.txt and memory.h.
--
error compiling committee
Blue Swirl writes:
> On Wed, Aug 31, 2011 at 4:06 PM, Anthony Liguori
> wrote:
>> On 08/31/2011 09:35 AM, malc wrote:
>>>
>>> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>>>
Upper case field names are not okay. If you think coding style isn't
clear,
that's a bug in coding style.
--- On Wed, 31/8/11, Blue Swirl wrote:
> I agree about importance of consistency, though I'd even go
> further and reformat globally. New code gets introduced
> based on copying old code so the pain goes on.
I think this is the most important point.
I've worked on many projects where coding s
On Wed, Aug 31, 2011 at 7:23 PM, Anthony Liguori wrote:
> On 08/31/2011 02:12 PM, Edgar E. Iglesias wrote:
>>
>> On Wed, Aug 31, 2011 at 01:48:34PM -0500, Anthony Liguori wrote:
etc, etc. IMO, those bring codingstyle issues into the pretty much
neglectable space.
>>>
>>> I don't thi
On 08/31/2011 02:12 PM, Edgar E. Iglesias wrote:
On Wed, Aug 31, 2011 at 01:48:34PM -0500, Anthony Liguori wrote:
etc, etc. IMO, those bring codingstyle issues into the pretty much
neglectable space.
I don't think we lack contributors. Documentation and tests are
really about discipline. If
On Wed, Aug 31, 2011 at 09:12:06PM +0200, Edgar E. Iglesias wrote:
> On Wed, Aug 31, 2011 at 01:48:34PM -0500, Anthony Liguori wrote:
> > On 08/31/2011 12:59 PM, Edgar E. Iglesias wrote:
> > >On Wed, Aug 31, 2011 at 11:06:11AM -0500, Anthony Liguori wrote:
> > >>On 08/31/2011 09:35 AM, malc wrote:
On Wed, Aug 31, 2011 at 01:48:34PM -0500, Anthony Liguori wrote:
> On 08/31/2011 12:59 PM, Edgar E. Iglesias wrote:
> >On Wed, Aug 31, 2011 at 11:06:11AM -0500, Anthony Liguori wrote:
> >>On 08/31/2011 09:35 AM, malc wrote:
> >>>On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >>>
> Upper case fie
On Wed, Aug 31, 2011 at 06:46:37PM +, Blue Swirl wrote:
> On Wed, Aug 31, 2011 at 5:59 PM, Edgar E. Iglesias
> wrote:
> > On Wed, Aug 31, 2011 at 11:06:11AM -0500, Anthony Liguori wrote:
> >> On 08/31/2011 09:35 AM, malc wrote:
> >> >On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >> >
> >> >>Up
On Wed, 31 Aug 2011, Blue Swirl wrote:
> On Wed, Aug 31, 2011 at 4:24 PM, malc wrote:
> > On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >
> >> On 08/31/2011 09:35 AM, malc wrote:
> >> > On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >> >
> >> > > Upper case field names are not okay. If you think
On Wed, Aug 31, 2011 at 5:59 PM, Edgar E. Iglesias
wrote:
> On Wed, Aug 31, 2011 at 11:06:11AM -0500, Anthony Liguori wrote:
>> On 08/31/2011 09:35 AM, malc wrote:
>> >On Wed, 31 Aug 2011, Anthony Liguori wrote:
>> >
>> >>Upper case field names are not okay. If you think coding style isn't
>> >>
On 08/31/2011 12:59 PM, Edgar E. Iglesias wrote:
On Wed, Aug 31, 2011 at 11:06:11AM -0500, Anthony Liguori wrote:
On 08/31/2011 09:35 AM, malc wrote:
On Wed, 31 Aug 2011, Anthony Liguori wrote:
Upper case field names are not okay. If you think coding style isn't clear,
that's a bug in coding
On Wed, Aug 31, 2011 at 4:24 PM, malc wrote:
> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>
>> On 08/31/2011 09:35 AM, malc wrote:
>> > On Wed, 31 Aug 2011, Anthony Liguori wrote:
>> >
>> > > Upper case field names are not okay. If you think coding style isn't
>> > > clear,
>> > > that's a bug i
On Wed, Aug 31, 2011 at 4:06 PM, Anthony Liguori wrote:
> On 08/31/2011 09:35 AM, malc wrote:
>>
>> On Wed, 31 Aug 2011, Anthony Liguori wrote:
>>
>>> Upper case field names are not okay. If you think coding style isn't
>>> clear,
>>> that's a bug in coding style.
>>
>> Sez hu? Coding style is ga
On Wed, Aug 31, 2011 at 11:06:11AM -0500, Anthony Liguori wrote:
> On 08/31/2011 09:35 AM, malc wrote:
> >On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >
> >>Upper case field names are not okay. If you think coding style isn't clear,
> >>that's a bug in coding style.
> >
> >Sez hu? Coding style is
On Wed, 31 Aug 2011, Anthony Liguori wrote:
> On 08/31/2011 09:35 AM, malc wrote:
> > On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >
> > > Upper case field names are not okay. If you think coding style isn't
> > > clear,
> > > that's a bug in coding style.
> >
> > Sez hu? Coding style is garba
On 08/31/2011 09:35 AM, malc wrote:
On Wed, 31 Aug 2011, Anthony Liguori wrote:
Upper case field names are not okay. If you think coding style isn't clear,
that's a bug in coding style.
Sez hu? Coding style is garbage that should be thrown out of the window.
As for looking, yeah, i'm looking
On Wed, 31 Aug 2011, Anthony Liguori wrote:
> On 08/31/2011 08:51 AM, malc wrote:
> > On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >
> > > On 08/31/2011 08:39 AM, malc wrote:
> > > > On Wed, 31 Aug 2011, Anthony Liguori wrote:
> > > >
> > > > > On 08/31/2011 08:17 AM, malc wrote:
> > > > > > On
On 08/31/2011 08:51 AM, malc wrote:
On Wed, 31 Aug 2011, Anthony Liguori wrote:
On 08/31/2011 08:39 AM, malc wrote:
On Wed, 31 Aug 2011, Anthony Liguori wrote:
On 08/31/2011 08:17 AM, malc wrote:
On Tue, 30 Aug 2011, Anthony Liguori wrote:
On 08/30/2011 08:30 PM, malc wrote:
On Tue, 30 A
On Wed, 31 Aug 2011, Anthony Liguori wrote:
> On 08/31/2011 08:39 AM, malc wrote:
> > On Wed, 31 Aug 2011, Anthony Liguori wrote:
> >
> > > On 08/31/2011 08:17 AM, malc wrote:
> > > > On Tue, 30 Aug 2011, Anthony Liguori wrote:
> > > >
> > > > > On 08/30/2011 08:30 PM, malc wrote:
> > > > > > On
On 08/31/2011 08:39 AM, malc wrote:
On Wed, 31 Aug 2011, Anthony Liguori wrote:
On 08/31/2011 08:17 AM, malc wrote:
On Tue, 30 Aug 2011, Anthony Liguori wrote:
On 08/30/2011 08:30 PM, malc wrote:
On Tue, 30 Aug 2011, Anthony Liguori wrote:
This won't even come close to passing checkpatch.
On Wed, 31 Aug 2011, Anthony Liguori wrote:
> On 08/31/2011 08:17 AM, malc wrote:
> > On Tue, 30 Aug 2011, Anthony Liguori wrote:
> >
> > > On 08/30/2011 08:30 PM, malc wrote:
> > > > On Tue, 30 Aug 2011, Anthony Liguori wrote:
> > > >
> > > > > This won't even come close to passing checkpatch.p
--- On Wed, 31/8/11, malc wrote:
> From: malc
> Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
> To: "Anthony Liguori"
> Cc: qemu-devel@nongnu.org, "bifferos"
> Date: Wednesday, 31 August, 2011, 14:17
> On Tue, 30 Aug 2011, Anthony Liguori
On 08/31/2011 08:17 AM, malc wrote:
On Tue, 30 Aug 2011, Anthony Liguori wrote:
On 08/30/2011 08:30 PM, malc wrote:
On Tue, 30 Aug 2011, Anthony Liguori wrote:
This won't even come close to passing checkpatch.pl
Have you actually tried?
Sigh. I was hoping checkpatch.pl was more useful t
On Tue, 30 Aug 2011, Anthony Liguori wrote:
> On 08/30/2011 08:30 PM, malc wrote:
> > On Tue, 30 Aug 2011, Anthony Liguori wrote:
> >
> > > This won't even come close to passing checkpatch.pl
> >
> > Have you actually tried?
>
> Sigh. I was hoping checkpatch.pl was more useful than it appears
On 08/30/2011 08:30 PM, malc wrote:
On Tue, 30 Aug 2011, Anthony Liguori wrote:
This won't even come close to passing checkpatch.pl
Have you actually tried?
Sigh. I was hoping checkpatch.pl was more useful than it appears to be.
At any rate, the patch doesn't follow CODING_STYLE.
Regards
On Tue, 30 Aug 2011, Anthony Liguori wrote:
> This won't even come close to passing checkpatch.pl
Have you actually tried?
>
> Regards,
>
> Anthony Liguori
>
> On 08/30/2011 08:05 PM, bifferos wrote:
> >
> > Signed-off-by: Mark Kelly
> > diff --git a/Makefile.objs b/Makefile.objs
> > index 6
This won't even come close to passing checkpatch.pl
Regards,
Anthony Liguori
On 08/30/2011 08:05 PM, bifferos wrote:
Signed-off-by: Mark Kelly
diff --git a/Makefile.objs b/Makefile.objs
index 6991a9f..7d87503 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -240,6 +240,7 @@ hw-obj-$(CONFIG_P
Signed-off-by: Mark Kelly
diff --git a/Makefile.objs b/Makefile.objs
index 6991a9f..7d87503 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -240,6 +240,7 @@ hw-obj-$(CONFIG_PCNET_PCI) += pcnet-pci.o
hw-obj-$(CONFIG_PCNET_COMMON) += pcnet.o
hw-obj-$(CONFIG_E1000_PCI) += e1000.o
hw-obj-$(CONFI
32 matches
Mail list logo
