Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Corey Bryant
On 07/11/2012 10:57 AM, Paolo Bonzini wrote: Il 11/07/2012 16:56, Fabien Chouteau ha scritto: So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were inclined to do so... Unfortunately I don't have time to go deep into the code. It's not a feature I plan to use, so the quicke

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Paolo Bonzini
Il 11/07/2012 16:56, Fabien Chouteau ha scritto: >>> So indeed you could also use SIOCDEVPRIVATE / BRCTL_ADD_IF if you were >>> inclined to do so... >>> >>> >> >>> >> Unfortunately I don't have time to go deep into the code. It's not a >>> >> feature I plan to use, so the quickest so

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Fabien Chouteau
On 07/11/2012 04:22 PM, Corey Bryant wrote: > > > On 07/10/2012 09:37 AM, Fabien Chouteau wrote: >> On 07/10/2012 01:06 PM, Paolo Bonzini wrote: >>> Il 10/07/2012 13:02, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Corey Bryant
On 07/10/2012 09:37 AM, Fabien Chouteau wrote: On 07/10/2012 01:06 PM, Paolo Bonzini wrote: Il 10/07/2012 13:02, Fabien Chouteau ha scritto: Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Which ioctls? Please detect them, so that we c

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-11 Thread Fabien Chouteau
On 07/10/2012 07:29 PM, Andreas Färber wrote: > Am 10.07.2012 12:43, schrieb Fabien Chouteau: >> Bridge helper uses ioctl's not available on old Linux versions, we add >> this flag to disable the build. >> >> Signed-off-by: Fabien Chouteau >> --- >> Makefile |2 +- >> configure |8 ++

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Andreas Färber
Am 10.07.2012 12:43, schrieb Fabien Chouteau: > Bridge helper uses ioctl's not available on old Linux versions, we add > this flag to disable the build. > > Signed-off-by: Fabien Chouteau > --- > Makefile |2 +- > configure |8 > 2 files changed, 9 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Fabien Chouteau
On 07/10/2012 01:06 PM, Paolo Bonzini wrote: > Il 10/07/2012 13:02, Fabien Chouteau ha scritto: >> Bridge helper uses ioctl's not available on old Linux versions, we add >> this flag to disable the build. Which ioctls? Please detect them, so that we can also work around them

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 13:02, Fabien Chouteau ha scritto: >>> >> Bridge helper uses ioctl's not available on old Linux versions, we add >>> >> this flag to disable the build. >> > >> > Which ioctls? Please detect them, so that we can also work around them >> > perhaps. >> > > There SIOCBRADDIF at least,

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Fabien Chouteau
On 07/10/2012 12:44 PM, Paolo Bonzini wrote: > Il 10/07/2012 12:43, Fabien Chouteau ha scritto: >> Bridge helper uses ioctl's not available on old Linux versions, we add >> this flag to disable the build. > > Which ioctls? Please detect them, so that we can also work around them > perhaps. > Th

Re: [Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Paolo Bonzini
Il 10/07/2012 12:43, Fabien Chouteau ha scritto: > Bridge helper uses ioctl's not available on old Linux versions, we add > this flag to disable the build. Which ioctls? Please detect them, so that we can also work around them perhaps. Paolo

[Qemu-devel] [PATCH] Add --disable-bridge-helper configure flag

2012-07-10 Thread Fabien Chouteau
Bridge helper uses ioctl's not available on old Linux versions, we add this flag to disable the build. Signed-off-by: Fabien Chouteau --- Makefile |2 +- configure |8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 34d6a9e..b46c6b0 10064