Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Samuel Thibault
Edgar E. Iglesias, le Wed 14 May 2014 00:54:50 +, a écrit : > Minor nit, the comment in if_encap should say > "0.0.0.0 can not be a destination address..." D'oh :) Samuel

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Edgar E. Iglesias
On Wed, May 14, 2014 at 02:44:20AM +0200, Samuel Thibault wrote: > Edgar E. Iglesias, le Wed 14 May 2014 00:30:09 +, a écrit : > > > At best I could think of using the patch below, which avoids registering > > > anything for 0.0.0.0, and use a broadcast to answer a guest which > > > would have

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Samuel Thibault
Edgar E. Iglesias, le Wed 14 May 2014 00:30:09 +, a écrit : > > At best I could think of using the patch below, which avoids registering > > anything for 0.0.0.0, and use a broadcast to answer a guest which > > would have used 0.0.0.0 as a source for whatever reason. I don't find > > anything

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Edgar E. Iglesias
On Wed, May 14, 2014 at 12:15:47AM +0200, Samuel Thibault wrote: > Edgar E. Iglesias, le Thu 08 May 2014 06:59:22 +, a écrit : > > On Thu, May 08, 2014 at 08:50:33AM +0200, Samuel Thibault wrote: > > > Edgar E. Iglesias, le Thu 08 May 2014 06:10:18 +, a écrit : > > > > The search part looks

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-13 Thread Samuel Thibault
Edgar E. Iglesias, le Thu 08 May 2014 06:59:22 +, a écrit : > On Thu, May 08, 2014 at 08:50:33AM +0200, Samuel Thibault wrote: > > Edgar E. Iglesias, le Thu 08 May 2014 06:10:18 +, a écrit : > > > The search part looks OK to me but when adding to the arp table, don't > > > you at least want

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-08 Thread Edgar E. Iglesias
On Thu, May 08, 2014 at 08:50:33AM +0200, Samuel Thibault wrote: > Edgar E. Iglesias, le Thu 08 May 2014 06:10:18 +, a écrit : > > The search part looks OK to me but when adding to the arp table, don't > > you at least want to avoid adding mappings for 0.0.0.0/32? > > I don't see the gain, act

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-07 Thread Samuel Thibault
Edgar E. Iglesias, le Thu 08 May 2014 06:10:18 +, a écrit : > The search part looks OK to me but when adding to the arp table, don't > you at least want to avoid adding mappings for 0.0.0.0/32? I don't see the gain, actually. It would mean burning some CPU all the time just to save a small po

Re: [Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-07 Thread Edgar E. Iglesias
On Thu, May 08, 2014 at 12:15:09AM +0200, Samuel Thibault wrote: > Do not special-case addresses with zero host part, as we do not > necessarily know how big it is, and the guest can fake them anyway. Hi Samuel, The search part looks OK to me but when adding to the arp table, don't you at least

[Qemu-devel] [PATCH, DoS] slirp (arp): do not special-case bogus IP addresses

2014-05-07 Thread Samuel Thibault
Do not special-case addresses with zero host part, as we do not necessarily know how big it is, and the guest can fake them anyway. Signed-off-by: Samuel Thibault --- This is particularly bad actually, one can for instance simply do this inside a Linux guest ip addr add 192.0.0.0/1 dev eth0 an