Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries

2020-07-06 Thread Eric Blake
On 7/3/20 8:06 AM, Alberto Garcia wrote: +printf -v expected_bitmap "%llu" $expected_bitmap # Convert to unsigned Does the length modifier “ll” actually do anything? + +printf "L2 entry #%d: 0x%016lx %016lx\n" "$entry_no" "$entry" "$bitmap" Or the “l” here? Actually they don't (I

Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries

2020-07-03 Thread Alberto Garcia
On Fri 03 Jul 2020 03:47:41 PM CEST, Max Reitz wrote: +printf -v expected_bitmap "%llu" $expected_bitmap # Convert to unsigned >>> >>> Does the length modifier “ll” actually do anything? >>> + +printf "L2 entry #%d: 0x%016lx %016lx\n" "$entry_no" "$entry" "$bitmap

Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries

2020-07-03 Thread Max Reitz
On 03.07.20 15:06, Alberto Garcia wrote: > On Fri 03 Jul 2020 11:49:14 AM CEST, Max Reitz wrote: [...] >>> +expected_bitmap=0 >>> +for bit in $expected_alloc; do >>> +expected_bitmap=$(($expected_bitmap | (1 << $bit))) >>> +done >>> +for bit in $expected_zero; do >>> +

Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries

2020-07-03 Thread Alberto Garcia
On Fri 03 Jul 2020 11:49:14 AM CEST, Max Reitz wrote: >> +_supported_fmt qcow2 >> +_supported_proto file nfs >> +_supported_os Linux >> +_unsupported_imgopts extended_l2 compat=0.10 cluster_size data_file > > I’d also add a 'refcount_bits=1[^0-9]', because this test doesn’t pass > with refcount-bit

Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries

2020-07-03 Thread Max Reitz
On 28.06.20 13:02, Alberto Garcia wrote: > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/271 | 901 + > tests/qemu-iotests/271.out | 724 + > tests/qemu-iotests/group | 1 + > 3 files changed, 1626 insertions(+) >

[PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries

2020-06-28 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- tests/qemu-iotests/271 | 901 + tests/qemu-iotests/271.out | 724 + tests/qemu-iotests/group | 1 + 3 files changed, 1626 insertions(+) create mode 100755 tests/qemu-iotests/271 create mode