On Fri 03 Jul 2020 11:49:14 AM CEST, Max Reitz wrote: >> +_supported_fmt qcow2 >> +_supported_proto file nfs >> +_supported_os Linux >> +_unsupported_imgopts extended_l2 compat=0.10 cluster_size data_file > > I’d also add a 'refcount_bits=1[^0-9]', because this test doesn’t pass > with refcount-bits=1 (due to taking a snapshot at one point).
Ok >> + expected_bitmap=0 >> + for bit in $expected_alloc; do >> + expected_bitmap=$(($expected_bitmap | (1 << $bit))) >> + done >> + for bit in $expected_zero; do >> + expected_bitmap=$(($expected_bitmap | (1 << (32 + $bit)))) >> + done >> + printf -v expected_bitmap "%llu" $expected_bitmap # Convert to unsigned > > Does the length modifier “ll” actually do anything? > >> + >> + printf "L2 entry #%d: 0x%016lx %016lx\n" "$entry_no" "$entry" "$bitmap" > > Or the “l” here? Actually they don't (I just tested in i386 and x86_64), I assumed that it would require the length modifiers like in C. I'm tempted to leave them for clarity (using 'll' in both cases), opinions? Berto
