Re: [PATCH v7 15/42] target/arm: Implement LDG, STG, ST2G instructions

2020-06-18 Thread Richard Henderson
On 6/18/20 6:56 AM, Peter Maydell wrote: > The pseudocode for LDG has an >address = Align(address, TAG_GRANULE); > in it. I don't see where in this code is the equivalent; have I missed it? Nope, I missed it. r~

Re: [PATCH v7 15/42] target/arm: Implement LDG, STG, ST2G instructions

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Split out allocation_tag_mem. Handle atomicity of stores. > v3: Add X[t] input to these insns; require pre-cleaned addresses. > v5: Fix !32-byte aligned operation of st2g. > v6: Fix op2 extract

[PATCH v7 15/42] target/arm: Implement LDG, STG, ST2G instructions

2020-06-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Split out allocation_tag_mem. Handle atomicity of stores. v3: Add X[t] input to these insns; require pre-cleaned addresses. v5: Fix !32-byte aligned operation of st2g. v6: Fix op2 extract, stg pre/post-index, stores vs sp, commentary; use pre-computed